[libvirt] [PATCH 2/2] qemu: Remove qemuMonitorTextSetCPU

Peter Krempa posted 2 patches 6 years, 7 months ago
[libvirt] [PATCH 2/2] qemu: Remove qemuMonitorTextSetCPU
Posted by Peter Krempa 6 years, 7 months ago
It's not used any more.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_monitor_text.c | 30 ------------------------------
 src/qemu/qemu_monitor_text.h |  2 --
 2 files changed, 32 deletions(-)

diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
index 280cc58840..a15c3df76e 100644
--- a/src/qemu/qemu_monitor_text.c
+++ b/src/qemu/qemu_monitor_text.c
@@ -32,36 +32,6 @@

 VIR_LOG_INIT("qemu.qemu_monitor_text");

-int qemuMonitorTextSetCPU(qemuMonitorPtr mon, int cpu, bool online)
-{
-    char *cmd;
-    char *reply = NULL;
-    int ret = -1;
-
-    if (virAsprintf(&cmd, "cpu_set %d %s", cpu, online ? "online" : "offline") < 0)
-        return -1;
-
-    if (qemuMonitorHMPCommand(mon, cmd, &reply) < 0)
-        goto cleanup;
-
-    /* If the command failed qemu prints: 'unknown command'
-     * No message is printed on success it seems */
-    if (strstr(reply, "unknown command:")) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("cannot change vcpu count of this domain"));
-        goto cleanup;
-    }
-
-    ret = 0;
-
- cleanup:
-    VIR_FREE(reply);
-    VIR_FREE(cmd);
-
-    return ret;
-}
-
-
 int qemuMonitorTextAddDrive(qemuMonitorPtr mon,
                             const char *drivestr)
 {
diff --git a/src/qemu/qemu_monitor_text.h b/src/qemu/qemu_monitor_text.h
index 524bd1d5cb..ce6dd979a5 100644
--- a/src/qemu/qemu_monitor_text.h
+++ b/src/qemu/qemu_monitor_text.h
@@ -25,8 +25,6 @@

 #include "qemu_monitor.h"

-int qemuMonitorTextSetCPU(qemuMonitorPtr mon, int cpu, bool online);
-
 int qemuMonitorTextAddDrive(qemuMonitorPtr mon,
                              const char *drivestr);

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] qemu: Remove qemuMonitorTextSetCPU
Posted by Ján Tomko 6 years, 7 months ago
On Thu, Jun 20, 2019 at 01:22:27PM +0200, Peter Krempa wrote:
>It's not used any more.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_monitor_text.c | 30 ------------------------------
> src/qemu/qemu_monitor_text.h |  2 --
> 2 files changed, 32 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list