[libvirt] [PATCH 02/24] qemu_process: Drop cleanup label from qemuProcessUpdateGuestCPU

Jiri Denemark posted 24 patches 6 years, 7 months ago
There is a newer version of this series
[libvirt] [PATCH 02/24] qemu_process: Drop cleanup label from qemuProcessUpdateGuestCPU
Posted by Jiri Denemark 6 years, 7 months ago
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/qemu/qemu_process.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 1626796c19..144328c148 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -5893,8 +5893,6 @@ qemuProcessUpdateGuestCPU(virDomainDefPtr def,
                           virCapsPtr caps,
                           unsigned int flags)
 {
-    int ret = -1;
-
     if (!def->cpu)
         return 0;
 
@@ -5943,17 +5941,14 @@ qemuProcessUpdateGuestCPU(virDomainDefPtr def,
     if (virCPUUpdate(def->os.arch, def->cpu,
                      virQEMUCapsGetHostModel(qemuCaps, def->virtType,
                                              VIR_QEMU_CAPS_HOST_CPU_MIGRATABLE)) < 0)
-        goto cleanup;
+        return -1;
 
     if (virCPUTranslate(def->os.arch, def->cpu,
                         virQEMUCapsGetCPUDefinitions(qemuCaps, def->virtType)) < 0)
-        goto cleanup;
+        return -1;
 
     def->cpu->fallback = VIR_CPU_FALLBACK_FORBID;
-    ret = 0;
-
- cleanup:
-    return ret;
+    return 0;
 }
 
 
-- 
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 02/24] qemu_process: Drop cleanup label from qemuProcessUpdateGuestCPU
Posted by Ján Tomko 6 years, 7 months ago
On Wed, Jun 19, 2019 at 11:37:59AM +0200, Jiri Denemark wrote:
>Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
>---
> src/qemu/qemu_process.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list