qemu: remove json fields from domain and monitor objects

[libvirt] [PATCH 09/10] qemu: monitor: use VIR_AUTOFREE in qemuMonitor*VideoSize

Posted by Ján Tomko 6 years, 7 months ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_monitor.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index f19bbea8b9..1b2773c60a 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -1205,7 +1205,7 @@ qemuMonitorUpdateVideoMemorySize(qemuMonitorPtr mon,
                                  const char *videoName)
 {
     int ret = -1;
-    char *path = NULL;
+    VIR_AUTOFREE(char *) path = NULL;
 
     QEMU_CHECK_MONITOR(mon);
 
@@ -1219,9 +1219,7 @@ qemuMonitorUpdateVideoMemorySize(qemuMonitorPtr mon,
         return -1;
     }
 
-    ret = qemuMonitorJSONUpdateVideoMemorySize(mon, video, path);
-    VIR_FREE(path);
-    return ret;
+    return qemuMonitorJSONUpdateVideoMemorySize(mon, video, path);
 }
 
 
@@ -1237,7 +1235,7 @@ qemuMonitorUpdateVideoVram64Size(qemuMonitorPtr mon,
                                  const char *videoName)
 {
     int ret = -1;
-    char *path = NULL;
+    VIR_AUTOFREE(char *) path = NULL;
 
     QEMU_CHECK_MONITOR(mon);
 
@@ -1251,9 +1249,7 @@ qemuMonitorUpdateVideoVram64Size(qemuMonitorPtr mon,
         return -1;
     }
 
-    ret = qemuMonitorJSONUpdateVideoVram64Size(mon, video, path);
-    VIR_FREE(path);
-    return ret;
+    return qemuMonitorJSONUpdateVideoVram64Size(mon, video, path);
 }
 
 
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 09/10] qemu: monitor: use VIR_AUTOFREE in qemuMonitor*VideoSize

Posted by Peter Krempa 6 years, 7 months ago

On Sat, Jun 15, 2019 at 14:11:38 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_monitor.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list