All the code is mostly outdated and does not really help in most cases.

Since this was already proposed and I did not see anything against here
are the patches.

As a follow up I'll refactor and move the rest of qemu_parse_command.c
once this is out of the way.

you can fetch this by

 git fetch https://github.com/pipo/libvirt.git parse-command-delete

Peter Krempa (5):
  qemu: driver: Drop support for qemu-attach
  qemu: parse: Drop qemuParseCommandLinePid and friends
  qemu: driver: Remove support for native->XML conversion
  tests: Drop qemuargv2xmltest
  qemu: parse: Drop unused qemu command line parsing infrastructure

 src/check-aclrules.pl                         |    1 +
 src/qemu/qemu_domain.c                        |    2 +
 src/qemu/qemu_driver.c                        |  125 +-
 src/qemu/qemu_parse_command.c                 | 2714 +----------------
 src/qemu/qemu_parse_command.h                 |   23 -
 tests/Makefile.am                             |   11 +-
 tests/qemuargv2xmldata/boot-cdrom.args        |   22 -
 tests/qemuargv2xmldata/boot-cdrom.xml         |   35 -
 tests/qemuargv2xmldata/boot-floppy.args       |   23 -
 tests/qemuargv2xmldata/boot-floppy.xml        |   41 -
 tests/qemuargv2xmldata/boot-network.args      |   22 -
 tests/qemuargv2xmldata/boot-network.xml       |   34 -
 tests/qemuargv2xmldata/clock-localtime.args   |   23 -
 tests/qemuargv2xmldata/clock-localtime.xml    |   34 -
 tests/qemuargv2xmldata/clock-utc.args         |   22 -
 tests/qemuargv2xmldata/clock-utc.xml          |   34 -
 tests/qemuargv2xmldata/console-compat.args    |   22 -
 tests/qemuargv2xmldata/console-compat.xml     |   42 -
 tests/qemuargv2xmldata/disk-cdrom-empty.args  |   23 -
 tests/qemuargv2xmldata/disk-cdrom-empty.xml   |   40 -
 tests/qemuargv2xmldata/disk-cdrom.args        |   23 -
 tests/qemuargv2xmldata/disk-cdrom.xml         |   41 -
 .../disk-drive-boot-cdrom.args                |   23 -
 .../disk-drive-boot-cdrom.xml                 |   41 -
 .../disk-drive-boot-disk.args                 |   23 -
 .../qemuargv2xmldata/disk-drive-boot-disk.xml |   41 -
 .../disk-drive-cache-directsync.args          |   24 -
 .../disk-drive-cache-directsync.xml           |   41 -
 .../disk-drive-cache-unsafe.args              |   24 -
 .../disk-drive-cache-unsafe.xml               |   41 -
 .../disk-drive-cache-v2-none.args             |   23 -
 .../disk-drive-cache-v2-none.xml              |   41 -
 .../disk-drive-cache-v2-wb.args               |   24 -
 .../disk-drive-cache-v2-wb.xml                |   41 -
 .../disk-drive-cache-v2-wt.args               |   24 -
 .../disk-drive-cache-v2-wt.xml                |   41 -
 .../disk-drive-error-policy-enospace.args     |   24 -
 .../disk-drive-error-policy-enospace.xml      |   41 -
 .../disk-drive-error-policy-stop.args         |   24 -
 .../disk-drive-error-policy-stop.xml          |   41 -
 ...sk-drive-error-policy-wreport-rignore.args |   24 -
 ...isk-drive-error-policy-wreport-rignore.xml |   41 -
 .../qemuargv2xmldata/disk-drive-fmt-qcow.args |   23 -
 .../qemuargv2xmldata/disk-drive-fmt-qcow.xml  |   41 -
 .../disk-drive-network-gluster.args           |   25 -
 .../disk-drive-network-gluster.xml            |   41 -
 .../disk-drive-network-iscsi-auth.args        |   25 -
 .../disk-drive-network-iscsi-auth.xml         |   44 -
 .../disk-drive-network-iscsi.args             |   25 -
 .../disk-drive-network-iscsi.xml              |   41 -
 .../disk-drive-network-nbd-export.args        |   23 -
 .../disk-drive-network-nbd-export.xml         |   42 -
 .../disk-drive-network-nbd-ipv6-export.args   |   23 -
 .../disk-drive-network-nbd-ipv6-export.xml    |   42 -
 .../disk-drive-network-nbd-ipv6.args          |   23 -
 .../disk-drive-network-nbd-ipv6.xml           |   42 -
 .../disk-drive-network-nbd-unix.args          |   23 -
 .../disk-drive-network-nbd-unix.xml           |   42 -
 .../disk-drive-network-nbd.args               |   23 -
 .../disk-drive-network-nbd.xml                |   42 -
 .../disk-drive-network-rbd-auth.args          |   26 -
 .../disk-drive-network-rbd-auth.xml           |   47 -
 .../disk-drive-network-rbd-ceph-env.args      |   25 -
 .../disk-drive-network-rbd-ceph-env.xml       |   44 -
 .../disk-drive-network-rbd-ipv6.args          |   25 -
 .../disk-drive-network-rbd-ipv6.xml           |   45 -
 .../disk-drive-network-rbd.args               |   29 -
 .../disk-drive-network-rbd.xml                |   72 -
 .../disk-drive-network-sheepdog.args          |   23 -
 .../disk-drive-network-sheepdog.xml           |   42 -
 tests/qemuargv2xmldata/disk-floppy.args       |   24 -
 tests/qemuargv2xmldata/disk-floppy.xml        |   47 -
 tests/qemuargv2xmldata/disk-many.args         |   25 -
 tests/qemuargv2xmldata/disk-many.xml          |   52 -
 tests/qemuargv2xmldata/disk-usb.args          |   23 -
 tests/qemuargv2xmldata/disk-usb.xml           |   39 -
 tests/qemuargv2xmldata/disk-virtio.args       |   25 -
 tests/qemuargv2xmldata/disk-virtio.xml        |   53 -
 .../graphics-sdl-fullscreen.args              |   25 -
 .../graphics-sdl-fullscreen.xml               |   39 -
 tests/qemuargv2xmldata/graphics-sdl.args      |   24 -
 tests/qemuargv2xmldata/graphics-sdl.xml       |   39 -
 .../qemuargv2xmldata/graphics-vnc-policy.args |   23 -
 .../qemuargv2xmldata/graphics-vnc-policy.xml  |   41 -
 tests/qemuargv2xmldata/graphics-vnc-sasl.args |   24 -
 tests/qemuargv2xmldata/graphics-vnc-sasl.xml  |   41 -
 .../qemuargv2xmldata/graphics-vnc-socket.args |   23 -
 .../qemuargv2xmldata/graphics-vnc-socket.xml  |   41 -
 tests/qemuargv2xmldata/graphics-vnc-tls.args  |   24 -
 tests/qemuargv2xmldata/graphics-vnc-tls.xml   |   41 -
 .../graphics-vnc-websocket.args               |   22 -
 .../graphics-vnc-websocket.xml                |   32 -
 tests/qemuargv2xmldata/graphics-vnc.args      |   23 -
 tests/qemuargv2xmldata/graphics-vnc.xml       |   41 -
 .../qemuargv2xmldata/hostdev-pci-address.args |   23 -
 .../qemuargv2xmldata/hostdev-pci-address.xml  |   40 -
 .../qemuargv2xmldata/hostdev-usb-address.args |   23 -
 .../qemuargv2xmldata/hostdev-usb-address.xml  |   39 -
 tests/qemuargv2xmldata/hyperv-panic.args      |   21 -
 tests/qemuargv2xmldata/hyperv-panic.xml       |   29 -
 tests/qemuargv2xmldata/hyperv.args            |   21 -
 tests/qemuargv2xmldata/hyperv.xml             |   33 -
 tests/qemuargv2xmldata/input-usbmouse.args    |   23 -
 tests/qemuargv2xmldata/input-usbmouse.xml     |   35 -
 tests/qemuargv2xmldata/input-usbtablet.args   |   23 -
 tests/qemuargv2xmldata/input-usbtablet.xml    |   35 -
 tests/qemuargv2xmldata/kvm-features.args      |   21 -
 tests/qemuargv2xmldata/kvm-features.xml       |   31 -
 tests/qemuargv2xmldata/kvmclock.args          |   22 -
 tests/qemuargv2xmldata/kvmclock.xml           |   30 -
 .../machine-aeskeywrap-off-argv.args          |   18 -
 .../machine-aeskeywrap-off-argv.xml           |   23 -
 .../machine-aeskeywrap-on-argv.args           |   18 -
 .../machine-aeskeywrap-on-argv.xml            |   23 -
 tests/qemuargv2xmldata/machine-core-off.args  |   22 -
 tests/qemuargv2xmldata/machine-core-off.xml   |   34 -
 tests/qemuargv2xmldata/machine-core-on.args   |   22 -
 tests/qemuargv2xmldata/machine-core-on.xml    |   34 -
 .../machine-deakeywrap-off-argv.args          |   18 -
 .../machine-deakeywrap-off-argv.xml           |   23 -
 .../machine-deakeywrap-on-argv.args           |   18 -
 .../machine-deakeywrap-on-argv.xml            |   23 -
 .../machine-keywrap-none-argv.args            |   18 -
 .../machine-keywrap-none-argv.xml             |   20 -
 .../qemuargv2xmldata/mem-scale-maxmemory.args |   22 -
 .../qemuargv2xmldata/mem-scale-maxmemory.xml  |   38 -
 tests/qemuargv2xmldata/mem-scale.args         |   22 -
 tests/qemuargv2xmldata/mem-scale.xml          |   37 -
 tests/qemuargv2xmldata/migrate.args           |   23 -
 tests/qemuargv2xmldata/migrate.xml            |   34 -
 tests/qemuargv2xmldata/misc-acpi.args         |   21 -
 tests/qemuargv2xmldata/misc-acpi.xml          |   37 -
 tests/qemuargv2xmldata/misc-disable-s3.args   |   23 -
 tests/qemuargv2xmldata/misc-disable-s3.xml    |   37 -
 .../misc-disable-suspends.args                |   24 -
 .../misc-disable-suspends.xml                 |   38 -
 tests/qemuargv2xmldata/misc-enable-s4.args    |   23 -
 tests/qemuargv2xmldata/misc-enable-s4.xml     |   37 -
 tests/qemuargv2xmldata/misc-no-reboot.args    |   23 -
 tests/qemuargv2xmldata/misc-no-reboot.xml     |   34 -
 tests/qemuargv2xmldata/misc-uuid.args         |   21 -
 tests/qemuargv2xmldata/misc-uuid.xml          |   37 -
 tests/qemuargv2xmldata/net-eth-ifname.args    |   23 -
 tests/qemuargv2xmldata/net-eth-ifname.xml     |   41 -
 tests/qemuargv2xmldata/net-eth.args           |   23 -
 tests/qemuargv2xmldata/net-eth.xml            |   40 -
 tests/qemuargv2xmldata/net-user.args          |   23 -
 tests/qemuargv2xmldata/net-user.xml           |   39 -
 tests/qemuargv2xmldata/net-virtio.args        |   23 -
 tests/qemuargv2xmldata/net-virtio.xml         |   39 -
 .../nographics-vga-display.args               |   23 -
 .../nographics-vga-display.xml                |   34 -
 tests/qemuargv2xmldata/nographics-vga.args    |   23 -
 tests/qemuargv2xmldata/nographics-vga.xml     |   34 -
 tests/qemuargv2xmldata/nomachine-ppc64.args   |   11 -
 tests/qemuargv2xmldata/nomachine-ppc64.xml    |   50 -
 tests/qemuargv2xmldata/nomachine-x86_64.args  |   11 -
 tests/qemuargv2xmldata/nomachine-x86_64.xml   |   49 -
 tests/qemuargv2xmldata/nosharepages.args      |   22 -
 tests/qemuargv2xmldata/nosharepages.xml       |   37 -
 tests/qemuargv2xmldata/parallel-tcp.args      |   22 -
 tests/qemuargv2xmldata/parallel-tcp.xml       |   39 -
 tests/qemuargv2xmldata/pseries-disk.args      |   18 -
 tests/qemuargv2xmldata/pseries-disk.xml       |   50 -
 tests/qemuargv2xmldata/pseries-nvram.args     |   22 -
 tests/qemuargv2xmldata/pseries-nvram.xml      |   30 -
 tests/qemuargv2xmldata/qemu-ns-no-env.args    |   23 -
 tests/qemuargv2xmldata/qemu-ns-no-env.xml     |   38 -
 .../reboot-timeout-disabled.args              |   21 -
 .../reboot-timeout-disabled.xml               |   26 -
 .../reboot-timeout-enabled.args               |   21 -
 .../reboot-timeout-enabled.xml                |   26 -
 tests/qemuargv2xmldata/restore-v2.args        |   23 -
 tests/qemuargv2xmldata/restore-v2.xml         |   34 -
 tests/qemuargv2xmldata/serial-dev.args        |   22 -
 tests/qemuargv2xmldata/serial-dev.xml         |   44 -
 tests/qemuargv2xmldata/serial-file.args       |   22 -
 tests/qemuargv2xmldata/serial-file.xml        |   44 -
 tests/qemuargv2xmldata/serial-many.args       |   23 -
 tests/qemuargv2xmldata/serial-many.xml        |   48 -
 tests/qemuargv2xmldata/serial-pty.args        |   22 -
 tests/qemuargv2xmldata/serial-pty.xml         |   42 -
 tests/qemuargv2xmldata/serial-tcp-telnet.args |   22 -
 tests/qemuargv2xmldata/serial-tcp-telnet.xml  |   46 -
 tests/qemuargv2xmldata/serial-tcp.args        |   22 -
 tests/qemuargv2xmldata/serial-tcp.xml         |   46 -
 tests/qemuargv2xmldata/serial-udp.args        |   23 -
 tests/qemuargv2xmldata/serial-udp.xml         |   52 -
 tests/qemuargv2xmldata/serial-unix.args       |   22 -
 tests/qemuargv2xmldata/serial-unix.xml        |   44 -
 tests/qemuargv2xmldata/serial-vc.args         |   22 -
 tests/qemuargv2xmldata/serial-vc.xml          |   42 -
 tests/qemuargv2xmldata/smp.args               |   22 -
 tests/qemuargv2xmldata/smp.xml                |   37 -
 tests/qemuargv2xmldata/sound.args             |   23 -
 tests/qemuargv2xmldata/sound.xml              |   42 -
 tests/qemuargv2xmldata/watchdog.args          |   24 -
 tests/qemuargv2xmldata/watchdog.xml           |   35 -
 tests/qemuargv2xmltest.c                      |  323 --
 tests/virschematest.c                         |    2 +-
 200 files changed, 18 insertions(+), 9093 deletions(-)
 delete mode 100644 tests/qemuargv2xmldata/boot-cdrom.args
 delete mode 100644 tests/qemuargv2xmldata/boot-cdrom.xml
 delete mode 100644 tests/qemuargv2xmldata/boot-floppy.args
 delete mode 100644 tests/qemuargv2xmldata/boot-floppy.xml
 delete mode 100644 tests/qemuargv2xmldata/boot-network.args
 delete mode 100644 tests/qemuargv2xmldata/boot-network.xml
 delete mode 100644 tests/qemuargv2xmldata/clock-localtime.args
 delete mode 100644 tests/qemuargv2xmldata/clock-localtime.xml
 delete mode 100644 tests/qemuargv2xmldata/clock-utc.args
 delete mode 100644 tests/qemuargv2xmldata/clock-utc.xml
 delete mode 100644 tests/qemuargv2xmldata/console-compat.args
 delete mode 100644 tests/qemuargv2xmldata/console-compat.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-cdrom-empty.args
 delete mode 100644 tests/qemuargv2xmldata/disk-cdrom-empty.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-cdrom.args
 delete mode 100644 tests/qemuargv2xmldata/disk-cdrom.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-cdrom.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-cdrom.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-disk.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-disk.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-directsync.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-directsync.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-unsafe.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-unsafe.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-none.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-none.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wb.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wb.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wt.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wt.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-enospace.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-enospace.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-stop.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-stop.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-wreport-rignore.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-wreport-rignore.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-fmt-qcow.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-fmt-qcow.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-gluster.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-gluster.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi-auth.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi-auth.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-export.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-export.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6-export.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6-export.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-unix.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-unix.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-auth.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-auth.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ceph-env.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ceph-env.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ipv6.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ipv6.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-sheepdog.args
 delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-sheepdog.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-floppy.args
 delete mode 100644 tests/qemuargv2xmldata/disk-floppy.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-many.args
 delete mode 100644 tests/qemuargv2xmldata/disk-many.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-usb.args
 delete mode 100644 tests/qemuargv2xmldata/disk-usb.xml
 delete mode 100644 tests/qemuargv2xmldata/disk-virtio.args
 delete mode 100644 tests/qemuargv2xmldata/disk-virtio.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-sdl-fullscreen.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-sdl-fullscreen.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-sdl.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-sdl.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-policy.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-policy.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-sasl.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-sasl.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-socket.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-socket.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-tls.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-tls.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-websocket.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-websocket.xml
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc.args
 delete mode 100644 tests/qemuargv2xmldata/graphics-vnc.xml
 delete mode 100644 tests/qemuargv2xmldata/hostdev-pci-address.args
 delete mode 100644 tests/qemuargv2xmldata/hostdev-pci-address.xml
 delete mode 100644 tests/qemuargv2xmldata/hostdev-usb-address.args
 delete mode 100644 tests/qemuargv2xmldata/hostdev-usb-address.xml
 delete mode 100644 tests/qemuargv2xmldata/hyperv-panic.args
 delete mode 100644 tests/qemuargv2xmldata/hyperv-panic.xml
 delete mode 100644 tests/qemuargv2xmldata/hyperv.args
 delete mode 100644 tests/qemuargv2xmldata/hyperv.xml
 delete mode 100644 tests/qemuargv2xmldata/input-usbmouse.args
 delete mode 100644 tests/qemuargv2xmldata/input-usbmouse.xml
 delete mode 100644 tests/qemuargv2xmldata/input-usbtablet.args
 delete mode 100644 tests/qemuargv2xmldata/input-usbtablet.xml
 delete mode 100644 tests/qemuargv2xmldata/kvm-features.args
 delete mode 100644 tests/qemuargv2xmldata/kvm-features.xml
 delete mode 100644 tests/qemuargv2xmldata/kvmclock.args
 delete mode 100644 tests/qemuargv2xmldata/kvmclock.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-off-argv.args
 delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-off-argv.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-on-argv.args
 delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-on-argv.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-core-off.args
 delete mode 100644 tests/qemuargv2xmldata/machine-core-off.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-core-on.args
 delete mode 100644 tests/qemuargv2xmldata/machine-core-on.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-off-argv.args
 delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-off-argv.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-on-argv.args
 delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-on-argv.xml
 delete mode 100644 tests/qemuargv2xmldata/machine-keywrap-none-argv.args
 delete mode 100644 tests/qemuargv2xmldata/machine-keywrap-none-argv.xml
 delete mode 100644 tests/qemuargv2xmldata/mem-scale-maxmemory.args
 delete mode 100644 tests/qemuargv2xmldata/mem-scale-maxmemory.xml
 delete mode 100644 tests/qemuargv2xmldata/mem-scale.args
 delete mode 100644 tests/qemuargv2xmldata/mem-scale.xml
 delete mode 100644 tests/qemuargv2xmldata/migrate.args
 delete mode 100644 tests/qemuargv2xmldata/migrate.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-acpi.args
 delete mode 100644 tests/qemuargv2xmldata/misc-acpi.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-disable-s3.args
 delete mode 100644 tests/qemuargv2xmldata/misc-disable-s3.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-disable-suspends.args
 delete mode 100644 tests/qemuargv2xmldata/misc-disable-suspends.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-enable-s4.args
 delete mode 100644 tests/qemuargv2xmldata/misc-enable-s4.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-no-reboot.args
 delete mode 100644 tests/qemuargv2xmldata/misc-no-reboot.xml
 delete mode 100644 tests/qemuargv2xmldata/misc-uuid.args
 delete mode 100644 tests/qemuargv2xmldata/misc-uuid.xml
 delete mode 100644 tests/qemuargv2xmldata/net-eth-ifname.args
 delete mode 100644 tests/qemuargv2xmldata/net-eth-ifname.xml
 delete mode 100644 tests/qemuargv2xmldata/net-eth.args
 delete mode 100644 tests/qemuargv2xmldata/net-eth.xml
 delete mode 100644 tests/qemuargv2xmldata/net-user.args
 delete mode 100644 tests/qemuargv2xmldata/net-user.xml
 delete mode 100644 tests/qemuargv2xmldata/net-virtio.args
 delete mode 100644 tests/qemuargv2xmldata/net-virtio.xml
 delete mode 100644 tests/qemuargv2xmldata/nographics-vga-display.args
 delete mode 100644 tests/qemuargv2xmldata/nographics-vga-display.xml
 delete mode 100644 tests/qemuargv2xmldata/nographics-vga.args
 delete mode 100644 tests/qemuargv2xmldata/nographics-vga.xml
 delete mode 100644 tests/qemuargv2xmldata/nomachine-ppc64.args
 delete mode 100644 tests/qemuargv2xmldata/nomachine-ppc64.xml
 delete mode 100644 tests/qemuargv2xmldata/nomachine-x86_64.args
 delete mode 100644 tests/qemuargv2xmldata/nomachine-x86_64.xml
 delete mode 100644 tests/qemuargv2xmldata/nosharepages.args
 delete mode 100644 tests/qemuargv2xmldata/nosharepages.xml
 delete mode 100644 tests/qemuargv2xmldata/parallel-tcp.args
 delete mode 100644 tests/qemuargv2xmldata/parallel-tcp.xml
 delete mode 100644 tests/qemuargv2xmldata/pseries-disk.args
 delete mode 100644 tests/qemuargv2xmldata/pseries-disk.xml
 delete mode 100644 tests/qemuargv2xmldata/pseries-nvram.args
 delete mode 100644 tests/qemuargv2xmldata/pseries-nvram.xml
 delete mode 100644 tests/qemuargv2xmldata/qemu-ns-no-env.args
 delete mode 100644 tests/qemuargv2xmldata/qemu-ns-no-env.xml
 delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-disabled.args
 delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-disabled.xml
 delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-enabled.args
 delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-enabled.xml
 delete mode 100644 tests/qemuargv2xmldata/restore-v2.args
 delete mode 100644 tests/qemuargv2xmldata/restore-v2.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-dev.args
 delete mode 100644 tests/qemuargv2xmldata/serial-dev.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-file.args
 delete mode 100644 tests/qemuargv2xmldata/serial-file.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-many.args
 delete mode 100644 tests/qemuargv2xmldata/serial-many.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-pty.args
 delete mode 100644 tests/qemuargv2xmldata/serial-pty.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-tcp-telnet.args
 delete mode 100644 tests/qemuargv2xmldata/serial-tcp-telnet.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-tcp.args
 delete mode 100644 tests/qemuargv2xmldata/serial-tcp.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-udp.args
 delete mode 100644 tests/qemuargv2xmldata/serial-udp.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-unix.args
 delete mode 100644 tests/qemuargv2xmldata/serial-unix.xml
 delete mode 100644 tests/qemuargv2xmldata/serial-vc.args
 delete mode 100644 tests/qemuargv2xmldata/serial-vc.xml
 delete mode 100644 tests/qemuargv2xmldata/smp.args
 delete mode 100644 tests/qemuargv2xmldata/smp.xml
 delete mode 100644 tests/qemuargv2xmldata/sound.args
 delete mode 100644 tests/qemuargv2xmldata/sound.xml
 delete mode 100644 tests/qemuargv2xmldata/watchdog.args
 delete mode 100644 tests/qemuargv2xmldata/watchdog.xml
 delete mode 100644 tests/qemuargv2xmltest.c

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Jun 14, 2019 at 03:30:22PM +0200, Peter Krempa wrote:
>All the code is mostly outdated and does not really help in most cases.
>
>Since this was already proposed and I did not see anything against here
>are the patches.
>
>As a follow up I'll refactor and move the rest of qemu_parse_command.c
>once this is out of the way.
>
>you can fetch this by
>
> git fetch https://github.com/pipo/libvirt.git parse-command-delete
>
>Peter Krempa (5):
>  qemu: driver: Drop support for qemu-attach
>  qemu: parse: Drop qemuParseCommandLinePid and friends
>  qemu: driver: Remove support for native->XML conversion
>  tests: Drop qemuargv2xmltest
>  qemu: parse: Drop unused qemu command line parsing infrastructure
>
> src/check-aclrules.pl                         |    1 +
> src/qemu/qemu_domain.c                        |    2 +
[...]
> delete mode 100644 tests/qemuargv2xmldata/watchdog.args
> delete mode 100644 tests/qemuargv2xmldata/watchdog.xml
> delete mode 100644 tests/qemuargv2xmltest.c
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

drvqemu.html might also need tuning

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, 2019-06-14 at 15:53 +0200, Ján Tomko wrote:
> On Fri, Jun 14, 2019 at 03:30:22PM +0200, Peter Krempa wrote:
> > All the code is mostly outdated and does not really help in most cases.
> > 
> > Since this was already proposed and I did not see anything against here
> > are the patches.
> > 
> > As a follow up I'll refactor and move the rest of qemu_parse_command.c
> > once this is out of the way.
> >
[...]
> drvqemu.html might also need tuning

In addition to that, you need to update the API documentation for
virDomainQemuAttach() and the virsh(1) man page at the very least.

IIRC we have a way to hide virsh commands from the help output: we
probably want to do that, too.

Mentioning this change in the release notes is another no brainer.

Once the stuff mentioned above, the nits I've pointed out separately,
and the issues spotted by Jano have been taken care of, and assuming
we let this sit on the list for a while so that all interested
parties are given a fair chance to express their dissent before it's
pushed, then

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list