qemu: External disk snapshot code refactors/cleanups (blockdev-add saga)

[libvirt] [PATCH 02/13] qemu: Use VIR_AUTOPTR in qemuDomainSnapshotCreateDiskActive

Posted by Peter Krempa 6 years, 8 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9c6221d3b2..8093b27656 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -15235,7 +15235,7 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
                                    qemuDomainAsyncJob asyncJob)
 {
     qemuDomainObjPrivatePtr priv = vm->privateData;
-    virJSONValuePtr actions = NULL;
+    VIR_AUTOPTR(virJSONValue) actions = NULL;
     bool do_transaction = false;
     int ret = 0;
     size_t i;
@@ -15341,7 +15341,6 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,

  cleanup:
     qemuDomainSnapshotDiskDataFree(diskdata, snapdef->ndisks, driver, vm);
-    virJSONValueFree(actions);

     if (orig_err) {
         virSetError(orig_err);
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/13] qemu: Use VIR_AUTOPTR in qemuDomainSnapshotCreateDiskActive

Posted by Ján Tomko 6 years, 8 months ago

On Wed, Jun 05, 2019 at 05:28:24PM +0200, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list