qemu: cleanups and improvements of blockjob handling (blockdev-add saga)

[libvirt] [PATCH 02/12] qemu: blockjob: Fix documentation for 'newstate' of _qemuBlockJobData

Posted by Peter Krempa 6 years, 8 months ago

When used with the new job handler the values will also include some of
the non-public values from qemuBlockjobState. Modify the comment to
clarify this.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_blockjob.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_blockjob.h b/src/qemu/qemu_blockjob.h
index 31d8151ef5..772cc5cba1 100644
--- a/src/qemu/qemu_blockjob.h
+++ b/src/qemu/qemu_blockjob.h
@@ -76,7 +76,7 @@ struct _qemuBlockJobData {
     char *errmsg;
     bool synchronous; /* API call is waiting for this job */

-    int newstate; /* virConnectDomainEventBlockJobStatus - new state to be processed */
+    int newstate; /* qemuBlockjobState, subset of events emitted by qemu */
 };


-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/12] qemu: blockjob: Fix documentation for 'newstate' of _qemuBlockJobData

Posted by Ján Tomko 6 years, 8 months ago

On Fri, May 17, 2019 at 01:19:48PM +0200, Peter Krempa wrote:
>When used with the new job handler the values will also include some of
>the non-public values from qemuBlockjobState. Modify the comment to
>clarify this.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_blockjob.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list