1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH 0/3] docs: hacking: Discourage some patterns to help code readability

Peter Krempa posted 3 patches 4 years, 11 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1557398401.git.pkrempa@redhat.com
docs/hacking.html.in | 61 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
[libvirt] [PATCH 0/3] docs: hacking: Discourage some patterns to help code readability
Posted by Peter Krempa 4 years, 11 months ago 
Peter Krempa (3):
  docs: hacking: Document few practices for creating error messages
  docs: hacking: Add good practices for shortening conditional
    expressions
  docs: hacking: Discourage use of the ternary operator and ban it's
    abuse

 docs/hacking.html.in | 61 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] docs: hacking: Discourage some patterns to help code readability
Posted by Peter Krempa 4 years, 11 months ago 
On Thu, May 09, 2019 at 12:43:31 +0200, Peter Krempa wrote:
> Peter Krempa (3):
>   docs: hacking: Document few practices for creating error messages
>   docs: hacking: Add good practices for shortening conditional
>     expressions
>   docs: hacking: Discourage use of the ternary operator and ban it's
>     abuse
> 
>  docs/hacking.html.in | 61 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)

Ping?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] docs: hacking: Discourage some patterns to help code readability
Posted by Eric Blake 4 years, 11 months ago 
On 5/21/19 7:52 AM, Peter Krempa wrote:
> On Thu, May 09, 2019 at 12:43:31 +0200, Peter Krempa wrote:
>> Peter Krempa (3):
>>   docs: hacking: Document few practices for creating error messages
>>   docs: hacking: Add good practices for shortening conditional
>>     expressions
>>   docs: hacking: Discourage use of the ternary operator and ban it's
>>     abuse
>>
>>  docs/hacking.html.in | 61 ++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 61 insertions(+)
> 
> Ping?

More work for me on my incremental backup series, but I can agree to all
three points.

Once you fix the typo,
ACK series

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.