On Thu, Jul 04, 2019 at 08:22:04AM +0200, Michal Prívozník wrote:
> On 7/3/19 1:17 PM, Daniel P. Berrangé wrote:
> > On Wed, Jul 03, 2019 at 08:56:29AM +0200, Michal Prívozník wrote:
> >> On 6/20/19 2:39 PM, Michal Privoznik wrote:
> >>> On 6/17/19 3:34 PM, Daniel P. Berrangé wrote:
> >>>> On Mon, Jun 03, 2019 at 06:07:02PM +0200, Michal Privoznik wrote:
> >>>>> On 4/25/19 10:19 AM, Michal Privoznik wrote:
> >>>>>>
> >>>>>> This is meant for next release to have the most time possible for
> >>>>>> testing. Some of the patches were ACKed in v3 already but since they
> >>>>>> don't make sense on their own I haven't pushed them.
> >>>>>>
> >>>>>> v4 of:
> >>>>>>
> >>>>>> https://www.redhat.com/archives/libvir-list/2019-March/msg01948.html
> >>>>>>
> >>>>>> As usual, you can find (not only these) patches on my github:
> >>>>>>
> >>>>>> https://github.com/zippy2/libvirt branch xattr_fixes_v4
> >>>>>
> >>>>> Ping?
> >>>>
> >>>> Looks good - just have 1 question against patch 18 before I can ack
> >>>> that patch.
> >>>>
> >>>>
> >>>
> >>> Thank you both Dan and Cole for the review! However, given how close to
> >>> the freeze we are and how intrusive this change is, I'd rather keep
> >>> these in a local branch and merge only after the release to give us the
> >>> longest window possible for test.
> >>
> >> This is now pushed. I'll work on the follow up patches soon.
> >
> > Looks like we hit a unit test failure on the FreeBSD CI systems.
>
> Interestingly, I'm unable to reproduce on my virtual FreeBSD. From the
> CI logs it looks like the test did not pick up XATTR functions from
> qemusecuritymock but the real ones from util/virfile.c. But then again,
> something fishy must be going on since I cannot reproduce this on my
> FreeBSD machine.
I could reproduce it .... once I actually installed the prereqs to
make QEMU get enabled in configure - for some reason we have a dep
on readline in the m4/virt-yajl.m4 file that looks liek its probobly
a bug.
Anyway it turned out to be a wierd compiler optimization problem but
was easily worked around by just mocking one more symbol, so I didn't
bother to try to understand the root cause further.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list