conf: DEF_FEATURE tweaks

[libvirt] [PATCH 0/2] conf: DEF_FEATURE tweaks

Cole Robinson posted 2 patches 5 years ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1555512762.git.crobinso@redhat.com

src/conf/domain_conf.c |  6 ++----
src/test/test_driver.c | 10 +++++++++-
src/vmx/vmx.c          |  3 ++-
3 files changed, 13 insertions(+), 6 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] conf: DEF_FEATURE tweaks

Posted by Cole Robinson 5 years ago

After the net model enum patches, the test driver started rejecting
non-enum model strings. It should continue to accept unknown models
and generally act closer to the qemu driver. So let's add all of
qemu's DEF_FEATURE bits to match while we are at it (virt-manager will
want this for os firmware XML testing at least)

Fix an issue in the area while I'm here

Cole Robinson (2):
  test: match qemu VIR_DOMAIN_DEF_FEATURE* usage
  conf: Fix VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT validation

 src/conf/domain_conf.c |  6 ++----
 src/test/test_driver.c | 10 +++++++++-
 src/vmx/vmx.c          |  3 ++-
 3 files changed, 13 insertions(+), 6 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: DEF_FEATURE tweaks

Posted by Cole Robinson 4 years, 12 months ago

On 4/17/19 10:57 AM, Cole Robinson wrote:
> After the net model enum patches, the test driver started rejecting
> non-enum model strings. It should continue to accept unknown models
> and generally act closer to the qemu driver. So let's add all of
> qemu's DEF_FEATURE bits to match while we are at it (virt-manager will
> want this for os firmware XML testing at least)
> 
> Fix an issue in the area while I'm here
> 
> Cole Robinson (2):
>   test: match qemu VIR_DOMAIN_DEF_FEATURE* usage
>   conf: Fix VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT validation
> 
>  src/conf/domain_conf.c |  6 ++----
>  src/test/test_driver.c | 10 +++++++++-
>  src/vmx/vmx.c          |  3 ++-
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 

ping, first patch at least should go into the next release at least,
some valid testdriver XML usage may require it as explained above

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list