qemu: monitor: detect more snapshot errors

[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors

Cole Robinson posted 3 patches 5 years, 7 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1554919494.git.crobinso@redhat.com

src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------
1 file changed, 20 insertions(+), 19 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors

Posted by Cole Robinson 5 years, 7 months ago

qemu in Fedora 30 rejects migration if the VM has nested VMX
configured. This means managedsave and snapshots are rejected too.
Unfortunately the scraping we need to resort to with the text monitor
snapshot commands is not detecting that 'savevm' actually failed, so
the snapshot appears to succeed.

https://bugzilla.redhat.com/show_bug.cgi?id=1697997

qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors
(qemu commit 66363e9a43f), let's use that to detect error as well

Cole Robinson (3):
  qemu: monitor: cleanup loadvm error handling
  qemu: monitor cleanup delvm error handling
  qemu: monitor: check for common 'Error: ' string

 src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors

Posted by Michal Privoznik 5 years, 7 months ago

On 4/10/19 8:29 PM, Cole Robinson wrote:
> qemu in Fedora 30 rejects migration if the VM has nested VMX
> configured. This means managedsave and snapshots are rejected too.
> Unfortunately the scraping we need to resort to with the text monitor
> snapshot commands is not detecting that 'savevm' actually failed, so
> the snapshot appears to succeed.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1697997
> 
> qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors
> (qemu commit 66363e9a43f), let's use that to detect error as well
> 
> Cole Robinson (3):
>    qemu: monitor: cleanup loadvm error handling
>    qemu: monitor cleanup delvm error handling
>    qemu: monitor: check for common 'Error: ' string
> 
>   src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------
>   1 file changed, 20 insertions(+), 19 deletions(-)
> 


ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list