drop QEMU_CAPS*KQEMU

[libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU

Ján Tomko posted 2 patches 5 years ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1554281471.git.jtomko@redhat.com

src/qemu/qemu_capabilities.c | 248 +++++++++++++++++------------------
src/qemu/qemu_capabilities.h | 248 +++++++++++++++++------------------
2 files changed, 246 insertions(+), 250 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU

Posted by Ján Tomko 5 years ago

Ján Tomko (2):
  Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU
  fixup: regroup QEMU capabilities

 src/qemu/qemu_capabilities.c | 248 +++++++++++++++++------------------
 src/qemu/qemu_capabilities.h | 248 +++++++++++++++++------------------
 2 files changed, 246 insertions(+), 250 deletions(-)

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU

Posted by Andrea Bolognani 5 years ago

On Wed, 2019-04-03 at 10:51 +0200, Ján Tomko wrote:
> Ján Tomko (2):
>   Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU
>   fixup: regroup QEMU capabilities
> 
>  src/qemu/qemu_capabilities.c | 248 +++++++++++++++++------------------
>  src/qemu/qemu_capabilities.h | 248 +++++++++++++++++------------------
>  2 files changed, 246 insertions(+), 250 deletions(-)

This looks like a lot of churn just to remove 2 lines out of the 328
we have... I'm not sure whether it's worth the effort, and I would
almost certainly not put the time in myself, but since you already
have

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Maybe wait a few days before pushing though, just in case.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list