build: drop some old libs and relax GNU strictness

[libvirt] [PATCH 03/10] build: drop check for SASL1

Posted by Ján Tomko 6 years, 8 months ago

Even Debian 8 which we no longer support has 2.1.26.

https://repology.org/project/cyrus-sasl/versions

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 m4/virt-sasl.m4 | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/m4/virt-sasl.m4 b/m4/virt-sasl.m4
index 6ef24fd4b9..7ab9b2c368 100644
--- a/m4/virt-sasl.m4
+++ b/m4/virt-sasl.m4
@@ -22,10 +22,7 @@ AC_DEFUN([LIBVIRT_ARG_SASL],[
 ])
 
 AC_DEFUN([LIBVIRT_CHECK_SASL],[
-  LIBVIRT_CHECK_LIB_ALT([SASL], [sasl2],
-                        [sasl_client_init], [sasl/sasl.h],
-                        [SASL1], [sasl],
-                        [sasl_client_init], [sasl/sasl.h])
+  LIBVIRT_CHECK_LIB([SASL], [sasl2], [sasl_client_init], [sasl/sasl.h])
 ])
 
 AC_DEFUN([LIBVIRT_RESULT_SASL],[
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/10] build: drop check for SASL1

Posted by Daniel P. Berrangé 6 years, 8 months ago

On Wed, Apr 03, 2019 at 07:40:18AM +0200, Ján Tomko wrote:
> Even Debian 8 which we no longer support has 2.1.26.
> 
> https://repology.org/project/cyrus-sasl/versions
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  m4/virt-sasl.m4 | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/m4/virt-sasl.m4 b/m4/virt-sasl.m4
> index 6ef24fd4b9..7ab9b2c368 100644
> --- a/m4/virt-sasl.m4
> +++ b/m4/virt-sasl.m4
> @@ -22,10 +22,7 @@ AC_DEFUN([LIBVIRT_ARG_SASL],[
>  ])
>  
>  AC_DEFUN([LIBVIRT_CHECK_SASL],[
> -  LIBVIRT_CHECK_LIB_ALT([SASL], [sasl2],
> -                        [sasl_client_init], [sasl/sasl.h],
> -                        [SASL1], [sasl],
> -                        [sasl_client_init], [sasl/sasl.h])

IIRC, this was some wierdness with Solaris which called the
SASL2 library  libsasl instead of libsasl2.  Anyway we don't
support Solaris so it doesn't matter anymore.
 
> +  LIBVIRT_CHECK_LIB([SASL], [sasl2], [sasl_client_init], [sasl/sasl.h])
>  ])
>  
>  AC_DEFUN([LIBVIRT_RESULT_SASL],[
> -- 
> 2.19.2
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/10] build: drop check for SASL1

Posted by Daniel P. Berrangé 6 years, 8 months ago

On Wed, Apr 03, 2019 at 09:32:10AM +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 03, 2019 at 07:40:18AM +0200, Ján Tomko wrote:
> > Even Debian 8 which we no longer support has 2.1.26.
> > 
> > https://repology.org/project/cyrus-sasl/versions
> > 
> > Signed-off-by: Ján Tomko <jtomko@redhat.com>
> > ---
> >  m4/virt-sasl.m4 | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/m4/virt-sasl.m4 b/m4/virt-sasl.m4
> > index 6ef24fd4b9..7ab9b2c368 100644
> > --- a/m4/virt-sasl.m4
> > +++ b/m4/virt-sasl.m4
> > @@ -22,10 +22,7 @@ AC_DEFUN([LIBVIRT_ARG_SASL],[
> >  ])
> >  
> >  AC_DEFUN([LIBVIRT_CHECK_SASL],[
> > -  LIBVIRT_CHECK_LIB_ALT([SASL], [sasl2],
> > -                        [sasl_client_init], [sasl/sasl.h],
> > -                        [SASL1], [sasl],
> > -                        [sasl_client_init], [sasl/sasl.h])
> 
> IIRC, this was some wierdness with Solaris which called the
> SASL2 library  libsasl instead of libsasl2.  Anyway we don't
> support Solaris so it doesn't matter anymore.

Opps, meant to say

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list