build: drop some old libs and relax GNU strictness

[libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

Posted by Ján Tomko 6 years, 8 months ago

This function was added by
commit 6d5b969d4206208e91ca807b09aac75f2f428393
    librbd: add diff_iterate2 to API
git describe: v0.94-1009-g6d5b969d42 contains: v9.0.1~55^2~27

Effectively bump the required version to 9.0.1 now that we no
longer try to support Debian 8.

Ubuntu 16.04 has 10.2.11:
https://repology.org/project/ceph/versions

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 m4/virt-storage-rbd.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4
index f3d9d04908..a54cdb2cd1 100644
--- a/m4/virt-storage-rbd.m4
+++ b/m4/virt-storage-rbd.m4
@@ -32,7 +32,7 @@ AC_DEFUN([LIBVIRT_STORAGE_CHECK_RBD], [
 
       old_LIBS="$LIBS"
       LIBS="$LIBS $LIBRBD_LIBS"
-      AC_CHECK_FUNCS([rbd_get_features],[],[LIBRBD_FOUND=no])
+      AC_CHECK_FUNCS([rbd_diff_iterate2],[],[LIBRBD_FOUND=no])
       AC_CHECK_FUNCS([rbd_list2])
       LIBS="$old_LIBS"
     fi
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

Posted by Daniel P. Berrangé 6 years, 8 months ago

On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote:
> This function was added by
> commit 6d5b969d4206208e91ca807b09aac75f2f428393
>     librbd: add diff_iterate2 to API
> git describe: v0.94-1009-g6d5b969d42 contains: v9.0.1~55^2~27
> 
> Effectively bump the required version to 9.0.1 now that we no
> longer try to support Debian 8.
> 
> Ubuntu 16.04 has 10.2.11:
> https://repology.org/project/ceph/versions

This version only arrived in RHEL-7.6.  We've not said whether our
support policy applies to only the version latest update or RHEL
or not.  To me though it feels too soon to mandate RHEL-7.6 only
as people are generally pretty slow to update to latest releases.

> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  m4/virt-storage-rbd.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4
> index f3d9d04908..a54cdb2cd1 100644
> --- a/m4/virt-storage-rbd.m4
> +++ b/m4/virt-storage-rbd.m4
> @@ -32,7 +32,7 @@ AC_DEFUN([LIBVIRT_STORAGE_CHECK_RBD], [
>  
>        old_LIBS="$LIBS"
>        LIBS="$LIBS $LIBRBD_LIBS"
> -      AC_CHECK_FUNCS([rbd_get_features],[],[LIBRBD_FOUND=no])
> +      AC_CHECK_FUNCS([rbd_diff_iterate2],[],[LIBRBD_FOUND=no])
>        AC_CHECK_FUNCS([rbd_list2])
>        LIBS="$old_LIBS"
>      fi
> -- 
> 2.19.2
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

Posted by Peter Krempa 6 years, 8 months ago

On Wed, Apr 03, 2019 at 09:40:14 +0100, Daniel Berrange wrote:
> On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote:
> > This function was added by
> > commit 6d5b969d4206208e91ca807b09aac75f2f428393
> >     librbd: add diff_iterate2 to API
> > git describe: v0.94-1009-g6d5b969d42 contains: v9.0.1~55^2~27
> > 
> > Effectively bump the required version to 9.0.1 now that we no
> > longer try to support Debian 8.
> > 
> > Ubuntu 16.04 has 10.2.11:
> > https://repology.org/project/ceph/versions
> 
> This version only arrived in RHEL-7.6.  We've not said whether our
> support policy applies to only the version latest update or RHEL
> or not.  To me though it feels too soon to mandate RHEL-7.6 only
> as people are generally pretty slow to update to latest releases.

Are people who are slow to update which is mostly to avoid breaking
production systems really going to run upstream libvirtd?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

Posted by Daniel P. Berrangé 6 years, 8 months ago

On Wed, Apr 03, 2019 at 10:48:25AM +0200, Peter Krempa wrote:
> On Wed, Apr 03, 2019 at 09:40:14 +0100, Daniel Berrange wrote:
> > On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote:
> > > This function was added by
> > > commit 6d5b969d4206208e91ca807b09aac75f2f428393
> > >     librbd: add diff_iterate2 to API
> > > git describe: v0.94-1009-g6d5b969d42 contains: v9.0.1~55^2~27
> > > 
> > > Effectively bump the required version to 9.0.1 now that we no
> > > longer try to support Debian 8.
> > > 
> > > Ubuntu 16.04 has 10.2.11:
> > > https://repology.org/project/ceph/versions
> > 
> > This version only arrived in RHEL-7.6.  We've not said whether our
> > support policy applies to only the version latest update or RHEL
> > or not.  To me though it feels too soon to mandate RHEL-7.6 only
> > as people are generally pretty slow to update to latest releases.
> 
> Are people who are slow to update which is mostly to avoid breaking
> production systems really going to run upstream libvirtd?

Our platform support policy isn't merely about what hosts people can
run libvirt on, it is also about what developers contributing to libvirt
can use. Corporate developers cannot be assumed to have freedom to choose
their development platform - RHEL-7 may well be the only platform they
can use.

I don't see a serious downside to keeping this ceph support around for
longer, especially given that the new code was only just added a week
ago & is easy to fix the mistake mentioned in the next patch

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/10] rbd: depend on diff_iterate2

Posted by Peter Krempa 6 years, 8 months ago

On Wed, Apr 03, 2019 at 10:00:18 +0100, Daniel Berrange wrote:
> On Wed, Apr 03, 2019 at 10:48:25AM +0200, Peter Krempa wrote:
> > On Wed, Apr 03, 2019 at 09:40:14 +0100, Daniel Berrange wrote:
> > > On Wed, Apr 03, 2019 at 07:40:16AM +0200, Ján Tomko wrote:
> > > > This function was added by
> > > > commit 6d5b969d4206208e91ca807b09aac75f2f428393
> > > >     librbd: add diff_iterate2 to API
> > > > git describe: v0.94-1009-g6d5b969d42 contains: v9.0.1~55^2~27
> > > > 
> > > > Effectively bump the required version to 9.0.1 now that we no
> > > > longer try to support Debian 8.
> > > > 
> > > > Ubuntu 16.04 has 10.2.11:
> > > > https://repology.org/project/ceph/versions
> > > 
> > > This version only arrived in RHEL-7.6.  We've not said whether our
> > > support policy applies to only the version latest update or RHEL
> > > or not.  To me though it feels too soon to mandate RHEL-7.6 only
> > > as people are generally pretty slow to update to latest releases.
> > 
> > Are people who are slow to update which is mostly to avoid breaking
> > production systems really going to run upstream libvirtd?
> 
> Our platform support policy isn't merely about what hosts people can
> run libvirt on, it is also about what developers contributing to libvirt
> can use. Corporate developers cannot be assumed to have freedom to choose
> their development platform - RHEL-7 may well be the only platform they
> can use.

I think we should add a configure time check that advices them to look
for a better job. Oh wait I'm 2 days late for such a thing probably.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list