[libvirt] [PATCH 09/10] configure.ac: drop -Wno-obsolete from AM_INIT_AUTOMAKE

Ján Tomko posted 10 patches 6 years, 8 months ago
[libvirt] [PATCH 09/10] configure.ac: drop -Wno-obsolete from AM_INIT_AUTOMAKE
Posted by Ján Tomko 6 years, 8 months ago
Even Ubuntu 16.04 has automake 1.11.
Now that we no longer cater to automake 1.9, drop the comment
as well as the -Wno-obsolete option, since it does not seem to generate
any warnings anymore.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 configure.ac | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 104990c2c0..78e5ee9a28 100644
--- a/configure.ac
+++ b/configure.ac
@@ -22,11 +22,9 @@ AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_HEADERS([config.h])
 AH_BOTTOM([#include <config-post.h>])
 AC_CONFIG_MACRO_DIR([m4])
-dnl Make automake keep quiet about wildcards & other GNUmake-isms; also keep
-dnl quiet about the fact that we intentionally cater to automake 1.9
+dnl Make automake keep quiet about wildcards & other GNUmake-isms
 AM_INIT_AUTOMAKE([
     -Wno-portability
-    -Wno-obsolete
     tar-pax
     no-dist-gzip
     dist-xz
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 09/10] configure.ac: drop -Wno-obsolete from AM_INIT_AUTOMAKE
Posted by Daniel P. Berrangé 6 years, 8 months ago
On Wed, Apr 03, 2019 at 07:40:24AM +0200, Ján Tomko wrote:
> Even Ubuntu 16.04 has automake 1.11.
> Now that we no longer cater to automake 1.9, drop the comment
> as well as the -Wno-obsolete option, since it does not seem to generate
> any warnings anymore.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  configure.ac | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list