[v2] virjsontest: separate some tests into files

[libvirt] [PATCHv2 03/14] virjsontest: reword error messages in testJSONFromString

Posted by Ján Tomko 6 years, 10 months ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tests/virjsontest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/virjsontest.c b/tests/virjsontest.c
index 3c4bb4141a..51777ba770 100644
--- a/tests/virjsontest.c
+++ b/tests/virjsontest.c
@@ -29,16 +29,16 @@ testJSONFromString(const void *data)
 
     if (!json) {
         if (info->pass) {
-            VIR_TEST_VERBOSE("Fail to parse %s\n", info->doc);
+            VIR_TEST_VERBOSE("Failed to parse %s\n", info->doc);
             goto cleanup;
         } else {
-            VIR_TEST_DEBUG("Fail to parse %s\n", info->doc);
+            VIR_TEST_DEBUG("As expected, failed to parse %s\n", info->doc);
             ret = 0;
             goto cleanup;
         }
     } else {
         if (!info->pass) {
-            VIR_TEST_VERBOSE("Should not have parsed %s\n", info->name);
+            VIR_TEST_VERBOSE("Unexpected success while parsing %s\n", info->doc);
             goto cleanup;
         }
     }
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 03/14] virjsontest: reword error messages in testJSONFromString

Posted by Peter Krempa 6 years, 10 months ago

On Tue, Apr 02, 2019 at 17:41:42 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  tests/virjsontest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list