[libvirt] [PATCH v2 09/29] conf: Unexport virDomainStorageSourceFormat

Peter Krempa posted 29 patches 6 years, 10 months ago
[libvirt] [PATCH v2 09/29] conf: Unexport virDomainStorageSourceFormat
Posted by Peter Krempa 6 years, 10 months ago
It's not used outside of src/conf/domain_conf.c

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c   | 2 +-
 src/conf/domain_conf.h   | 5 -----
 src/libvirt_private.syms | 1 -
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index adb20e33f2..ec81d380d5 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -23716,7 +23716,7 @@ virDomainDiskSourceFormatPrivateData(virBufferPtr buf,
 }


-int
+static int
 virDomainStorageSourceFormat(virBufferPtr attrBuf,
                              virBufferPtr childBuf,
                              virStorageSourcePtr src,
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index f0c2a51212..cca81be013 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3457,11 +3457,6 @@ int virDomainDiskDefCheckDuplicateInfo(const virDomainDiskDef *a,
                                        const virDomainDiskDef *b)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);

-int virDomainStorageSourceFormat(virBufferPtr attrBuf,
-                                 virBufferPtr childBuf,
-                                 virStorageSourcePtr src,
-                                 unsigned int flags)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);

 int virDomainStorageSourceParse(xmlNodePtr node,
                                 xmlXPathContextPtr ctxt,
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index c26c525d37..681ff911b6 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -564,7 +564,6 @@ virDomainStateReasonToString;
 virDomainStateTypeFromString;
 virDomainStateTypeToString;
 virDomainStorageNetworkParseHost;
-virDomainStorageSourceFormat;
 virDomainStorageSourceParse;
 virDomainTaintTypeFromString;
 virDomainTaintTypeToString;
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 09/29] conf: Unexport virDomainStorageSourceFormat
Posted by Ján Tomko 6 years, 10 months ago
On Fri, Mar 22, 2019 at 07:00:45PM +0100, Peter Krempa wrote:
>It's not used outside of src/conf/domain_conf.c
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/domain_conf.c   | 2 +-
> src/conf/domain_conf.h   | 5 -----
> src/libvirt_private.syms | 1 -
> 3 files changed, 1 insertion(+), 7 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list