[libvirt] [PATCH 22/34] conf: Unexport virDomainStorageSourceParse

Peter Krempa posted 34 patches 6 years, 10 months ago
There is a newer version of this series
[libvirt] [PATCH 22/34] conf: Unexport virDomainStorageSourceParse
Posted by Peter Krempa 6 years, 10 months ago
Now that all external callers were changed we can stop exporting this
func.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c   | 2 +-
 src/conf/domain_conf.h   | 7 -------
 src/libvirt_private.syms | 1 -
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d2cc199ed5..e7f3bcf114 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9039,7 +9039,7 @@ virDomainDiskSourcePRParse(xmlNodePtr node,
 }


-int
+static int
 virDomainStorageSourceParse(xmlNodePtr node,
                             xmlXPathContextPtr ctxt,
                             virStorageSourcePtr src,
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a87e1b30b9..ad288d702b 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3469,13 +3469,6 @@ virDomainStorageSourceFormatFull(virBufferPtr buf,
                                  virDomainXMLOptionPtr xmlopt)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);

-int virDomainStorageSourceParse(xmlNodePtr node,
-                                xmlXPathContextPtr ctxt,
-                                virStorageSourcePtr src,
-                                unsigned int flags,
-                                virDomainXMLOptionPtr xmlopt)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
-
 virStorageSourcePtr
 virDomainStorageSourceParseFull(const char *typeXPath,
                                 const char *formatXPath,
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index e4a695de9f..4bdea3b58f 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -564,7 +564,6 @@ virDomainStateTypeFromString;
 virDomainStateTypeToString;
 virDomainStorageNetworkParseHost;
 virDomainStorageSourceFormatFull;
-virDomainStorageSourceParse;
 virDomainStorageSourceParseFull;
 virDomainTaintTypeFromString;
 virDomainTaintTypeToString;
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 22/34] conf: Unexport virDomainStorageSourceParse
Posted by Ján Tomko 6 years, 10 months ago
On Mon, Mar 18, 2019 at 04:55:11PM +0100, Peter Krempa wrote:
>Now that all external callers were changed we can stop exporting this
>func.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/domain_conf.c   | 2 +-
> src/conf/domain_conf.h   | 7 -------
> src/libvirt_private.syms | 1 -
> 3 files changed, 1 insertion(+), 9 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list