[v3] qemu_hotplug: Fix a rare race condition when detaching a device twice

[libvirt] [PATCH v3 0/5] qemu_hotplug: Fix a rare race condition when detaching a device twice

Michal Privoznik posted 5 patches 5 years, 1 month ago

Diff against v1 v2
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1552645269.git.mprivozn@redhat.com

src/qemu/qemu_domain.h       |   1 +
src/qemu/qemu_hotplug.c      | 278 +++++++++++++++--------------------
src/qemu/qemu_monitor.c      |  10 ++
src/qemu/qemu_monitor_json.c |   5 +
4 files changed, 134 insertions(+), 160 deletions(-)

Expand all Fold all

[libvirt] [PATCH v3 0/5] qemu_hotplug: Fix a rare race condition when detaching a device twice

Posted by Michal Privoznik 5 years, 1 month ago

v3 of:

https://www.redhat.com/archives/libvir-list/2019-March/msg00924.html

diff to v2:
- Dropped @enterMonitor from qemuDomainDeleteDevice,
- Simplified event checking since @vm is always locked after
@enterMonitor is dropped,
- Switched to plain qemuMonitorDelDevice for zpci device
- Added comment about error reporting to 3/5

Note that 3/5 was ACKed in v2.

Michal Prívozník (5):
  qemu_hotplug: Introduce and use qemuDomainDeleteDevice
  DO NOT APPLY: Simple reproducer
  qemuMonitorJSONDelDevice: Return -2 on DeviceNotFound error
  qemu_hotplug: Fix a rare race condition when detaching a device twice
  DO NOT APPLY: Revert simple reproducer

 src/qemu/qemu_domain.h       |   1 +
 src/qemu/qemu_hotplug.c      | 278 +++++++++++++++--------------------
 src/qemu/qemu_monitor.c      |  10 ++
 src/qemu/qemu_monitor_json.c |   5 +
 4 files changed, 134 insertions(+), 160 deletions(-)

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list