[v2] Define XDG variables for hypervisor domains

[libvirt] [PATCH v2 0/3] Define XDG variables for hypervisor domains

Posted by Erik Skultety 5 years, 1 month ago

v1 here:
https://www.redhat.com/archives/libvir-list/2019-March/msg00323.html

since v1:
As per conversation with Dan P.B:
- dropped XDG setting (apart from XDG_CACHE_HOME - we need that)
  for session QEMU
- dropped setting HOME for session mode (HOME is passed from the session)
- dropped previous patch 2 and decomposed the original patch into 2 units

So for v2, this is what the settings will look like:

system QEMU:
HOME=/var/lib/libvirt/qemu/domain-5-f-live \
XDG_DATA_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.local/share \
XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.cache \
XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.config \

session QEMU:
XDG_CACHE_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.cache \

NOTE: This version doesn't contain the test changes in order to bring down the
patch size, so this won't compile, if you want to try it, see my github with
full changeset:
https://github.com/eskultety/libvirt/tree/xdg-vars

Travis build:
https://travis-ci.org/eskultety/libvirt/builds/503560867

Erik Skultety (3):
  util: command: Introduce virCommandAddEnvXDG helper
  qemu: command: Enforce setting XDG variables for system QEMU
  qemu: command: Override HOME variable for system QEMU

 src/libvirt_private.syms |  1 +
 src/qemu/qemu_command.c  | 17 +++++++++++++++++
 src/util/vircommand.c    | 21 +++++++++++++++++++++
 src/util/vircommand.h    |  2 ++
 4 files changed, 41 insertions(+)

--
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/3] Define XDG variables for hypervisor domains

Posted by Erik Skultety 5 years, 1 month ago

On Fri, Mar 08, 2019 at 01:00:46PM +0100, Erik Skultety wrote:
> v1 here:
> https://www.redhat.com/archives/libvir-list/2019-March/msg00323.html
>
> since v1:
> As per conversation with Dan P.B:
> - dropped XDG setting (apart from XDG_CACHE_HOME - we need that)
>   for session QEMU
> - dropped setting HOME for session mode (HOME is passed from the session)
> - dropped previous patch 2 and decomposed the original patch into 2 units
>
> So for v2, this is what the settings will look like:
>
> system QEMU:
> HOME=/var/lib/libvirt/qemu/domain-5-f-live \
> XDG_DATA_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.local/share \
> XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.cache \
> XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.config \
>
> session QEMU:
> XDG_CACHE_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.cache \
>
> NOTE: This version doesn't contain the test changes in order to bring down the
> patch size, so this won't compile, if you want to try it, see my github with
> full changeset:
> https://github.com/eskultety/libvirt/tree/xdg-vars
>
> Travis build:
> https://travis-ci.org/eskultety/libvirt/builds/503560867

ping

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list