[v2] Couple of storage driver improvements

[libvirt] [PATCH v2 8/8] virsh-pool: Offer only active pool for pool-refresh completer

Posted by Michal Privoznik 6 years, 11 months ago

Only active pools can be refreshed. But our completer offers just
all pool, even inactive ones.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/virsh-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index d98fd80330..f641f5776c 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -735,7 +735,7 @@ static const vshCmdInfo info_pool_refresh[] = {
 };
 
 static const vshCmdOptDef opts_pool_refresh[] = {
-    VIRSH_COMMON_OPT_POOL_FULL(0),
+    VIRSH_COMMON_OPT_POOL_FULL(VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE),
 
     {.name = NULL}
 };
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 8/8] virsh-pool: Offer only active pool for pool-refresh completer

Posted by Pavel Hrdina 6 years, 10 months ago

On Wed, Mar 06, 2019 at 03:59:18PM +0100, Michal Privoznik wrote:
> Only active pools can be refreshed. But our completer offers just
> all pool, even inactive ones.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/virsh-pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list