Refactor virQEMUCapsInitQMPCommand (for BaselineHypervisorCPU using QEMU QMP exchanges)

[libvirt] [PATCH 03/20] qemu_process: Limit qemuProcessQMPNew to const input strings

Posted by Jiri Denemark 6 years, 11 months ago

From: Chris Venteicher <cventeic@redhat.com>

Add the const qualifier on non modified strings
(string only copied inside qemuProcessQMPNew)
so that const strings can be used directly in calls to
qemuProcessQMPNew in future patches.

Signed-off-by: Chris Venteicher <cventeic@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---

Notes:
    Version 7:
    - no change

 src/qemu/qemu_process.c | 2 +-
 src/qemu/qemu_process.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 05acdc6013..6b698c0622 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8340,7 +8340,7 @@ qemuProcessQMPFree(qemuProcessQMPPtr cmd)
 
 
 qemuProcessQMPPtr
-qemuProcessQMPNew(char *binary,
+qemuProcessQMPNew(const char *binary,
                   const char *libDir,
                   uid_t runUid,
                   gid_t runGid,
diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
index 4843210f76..fe79873967 100644
--- a/src/qemu/qemu_process.h
+++ b/src/qemu/qemu_process.h
@@ -231,7 +231,7 @@ struct _qemuProcessQMP {
     virDomainObjPtr vm;
 };
 
-qemuProcessQMPPtr qemuProcessQMPNew(char *binary,
+qemuProcessQMPPtr qemuProcessQMPNew(const char *binary,
                                     const char *libDir,
                                     uid_t runUid,
                                     gid_t runGid,
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/20] qemu_process: Limit qemuProcessQMPNew to const input strings

Posted by Ján Tomko 6 years, 11 months ago

On Tue, Feb 19, 2019 at 10:04:46AM +0100, Jiri Denemark wrote:
>From: Chris Venteicher <cventeic@redhat.com>
>
>Add the const qualifier on non modified strings
>(string only copied inside qemuProcessQMPNew)
>so that const strings can be used directly in calls to
>qemuProcessQMPNew in future patches.
>
>Signed-off-by: Chris Venteicher <cventeic@redhat.com>
>Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
>Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
>---
>
>Notes:
>    Version 7:
>    - no change
>
> src/qemu/qemu_process.c | 2 +-
> src/qemu/qemu_process.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list