[libvirt] [PATCH 0/2] qemu_hotplug: Two simple qemuDomainDetachChrDevice fixes

Michal Privoznik posted 2 patches 5 years, 2 months ago
Test syntax-check passed
Failed in applying to current master (apply log)
src/qemu/qemu_hotplug.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
[libvirt] [PATCH 0/2] qemu_hotplug: Two simple qemuDomainDetachChrDevice fixes
Posted by Michal Privoznik 5 years, 2 months ago
*** BLURB HERE ***

Michal Prívozník (2):
  qemu_hotplug: Don't build device string in qemuDomainDetachChrDevice
  qemu_hotplug: Assume chardev alias always exists in
    qemuDomainDetachChrDevice

 src/qemu/qemu_hotplug.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] qemu_hotplug: Two simple qemuDomainDetachChrDevice fixes
Posted by John Ferlan 5 years, 2 months ago

On 2/14/19 4:56 AM, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (2):
>   qemu_hotplug: Don't build device string in qemuDomainDetachChrDevice
>   qemu_hotplug: Assume chardev alias always exists in
>     qemuDomainDetachChrDevice
> 
>  src/qemu/qemu_hotplug.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

FWIW:
I got one more for you too.... Your patches from guestfwd ... Coverity
got grumpy about @charAlias being assigned in (monitor), but being used
if rc == 0.

I missed it too - I was so focused on the other aspects

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list