1. Patchew
  2. Libvirt
  3. [libvirt] [PATCH 0/5] qemu: Fix guestfwd hot(un-)plug
  4. View patch

[libvirt] [PATCH 2/5] qemuL: Drop "user-" prefix for guestfwd netdev

Michal Privoznik posted 5 patches 6 years, 12 months ago
[libvirt] [PATCH 2/5] qemuL: Drop "user-" prefix for guestfwd netdev
Posted by Michal Privoznik 6 years, 12 months ago 
Introduced by d86c876a66e3.

There is no real need to have "user-" prefix for chardev.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_command.c                                       | 2 +-
 tests/qemuxml2argvdata/channel-guestfwd.args                  | 2 +-
 .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args  | 4 ++--
 .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args | 4 ++--
 tests/qemuxml2argvdata/name-escape.args                       | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 572d3bc20f..c20d8b02a9 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10857,7 +10857,7 @@ qemuBuildChannelChrDeviceStr(char **deviceStr,
         port = virSocketAddrGetPort(chr->target.addr);
 
         if (virAsprintf(deviceStr,
-                        "user,guestfwd=tcp:%s:%i-chardev:char%s,id=user-%s",
+                        "user,guestfwd=tcp:%s:%i-chardev:char%s,id=%s",
                         addr, port, chr->info.alias, chr->info.alias) < 0)
             goto cleanup;
         break;
diff --git a/tests/qemuxml2argvdata/channel-guestfwd.args b/tests/qemuxml2argvdata/channel-guestfwd.args
index a82d5b6d4e..a5e9a12520 100644
--- a/tests/qemuxml2argvdata/channel-guestfwd.args
+++ b/tests/qemuxml2argvdata/channel-guestfwd.args
@@ -24,5 +24,5 @@ server,nowait \
 -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
 -device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 \
 -chardev pipe,id=charchannel0,path=/tmp/guestfwd \
--netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=user-channel0 \
+-netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=channel0 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3
diff --git a/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args b/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args
index e8776ca24e..da062968ff 100644
--- a/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args
+++ b/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args
@@ -24,8 +24,8 @@ server,nowait \
 -boot strict=on \
 -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
 -chardev socket,id=charchannel0,path=/tmp/guestfwd-listen.socket,server,nowait \
--netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=user-channel0 \
+-netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=channel0 \
 -chardev socket,id=charchannel1,path=/tmp/guestfwd-connect.socket \
--netdev user,guestfwd=tcp:10.0.2.1:4601-chardev:charchannel1,id=user-channel1 \
+-netdev user,guestfwd=tcp:10.0.2.1:4601-chardev:charchannel1,id=channel1 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x2 \
 -msg timestamp=on
diff --git a/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args b/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args
index db14217c1b..34a3d33f27 100644
--- a/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args
+++ b/tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args
@@ -25,9 +25,9 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
 -boot strict=on \
 -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
 -chardev socket,id=charchannel0,fd=1729,server,nowait \
--netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=user-channel0 \
+-netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=channel0 \
 -chardev socket,id=charchannel1,path=/tmp/guestfwd-connect.socket \
--netdev user,guestfwd=tcp:10.0.2.1:4601-chardev:charchannel1,id=user-channel1 \
+-netdev user,guestfwd=tcp:10.0.2.1:4601-chardev:charchannel1,id=channel1 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x2 \
 -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\
 resourcecontrol=deny \
diff --git a/tests/qemuxml2argvdata/name-escape.args b/tests/qemuxml2argvdata/name-escape.args
index b4cad57602..9190b0b921 100644
--- a/tests/qemuxml2argvdata/name-escape.args
+++ b/tests/qemuxml2argvdata/name-escape.args
@@ -36,7 +36,7 @@ cert3=cert3,db=/etc/pki/nssdb,,foo,id=smartcard0,bus=ccid0.0 \
 -chardev file,id=charserial1,path=/tmp/serial.log,,foo,append=on \
 -device isa-serial,chardev=charserial1,id=serial1 \
 -chardev pipe,id=charchannel0,path=/tmp/guestfwd,,foo \
--netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=user-channel0 \
+-netdev user,guestfwd=tcp:10.0.2.1:4600-chardev:charchannel0,id=channel0 \
 -vnc unix:/tmp/lib/domain--1-foo=1,,bar=2/vnc.sock \
 -spice unix,addr=/tmp/lib/domain--1-foo=1,,bar=2/spice.sock,gl=on,\
 rendernode=/dev/dri/foo,,bar,seamless-migration=on \
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/5] qemuL: Drop "user-" prefix for guestfwd netdev
Posted by John Ferlan 6 years, 12 months ago 
$SUBJ:

s/qemuL:/qemu:/


On 2/11/19 10:40 AM, Michal Privoznik wrote:
> Introduced by d86c876a66e3.
> 
> There is no real need to have "user-" prefix for chardev.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_command.c                                       | 2 +-
>  tests/qemuxml2argvdata/channel-guestfwd.args                  | 2 +-
>  .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args  | 4 ++--
>  .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args | 4 ++--
>  tests/qemuxml2argvdata/name-escape.args                       | 2 +-
>  5 files changed, 7 insertions(+), 7 deletions(-)
> 

At least it wasn't "ua-" ;-)

Although I don't believe this patch is necessary. It's only made
necessary because two patches from now qemuDomainDetachChrDevice wants
to use tmpChr->info.alias instead of grabbing the alias that was used to
generated the command line from qemuBuildChrDeviceStr out of the @devstr.

Let me hold off on an R-by for this until you give feedback on my patch4
comments...

John

BTW: looks to me like af249ea46 originally implemented using id= string
without the user- prefix.  Eventually 7b2f8cdd7c removed id=, but then
the above restores it; however, w/ user- prefix.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/5] qemuL: Drop "user-" prefix for guestfwd netdev
Posted by Michal Privoznik 6 years, 12 months ago 
On 2/12/19 11:08 PM, John Ferlan wrote:
> $SUBJ:
> 
> s/qemuL:/qemu:/
> 
> 
> On 2/11/19 10:40 AM, Michal Privoznik wrote:
>> Introduced by d86c876a66e3.
>>
>> There is no real need to have "user-" prefix for chardev.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>   src/qemu/qemu_command.c                                       | 2 +-
>>   tests/qemuxml2argvdata/channel-guestfwd.args                  | 2 +-
>>   .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args  | 4 ++--
>>   .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args | 4 ++--
>>   tests/qemuxml2argvdata/name-escape.args                       | 2 +-
>>   5 files changed, 7 insertions(+), 7 deletions(-)
>>
> 
> At least it wasn't "ua-" ;-)
> 
> Although I don't believe this patch is necessary. It's only made
> necessary because two patches from now qemuDomainDetachChrDevice wants
> to use tmpChr->info.alias instead of grabbing the alias that was used to
> generated the command line from qemuBuildChrDeviceStr out of the @devstr.
> 
> Let me hold off on an R-by for this until you give feedback on my patch4
> comments...

Given that guestfwd has a very limitted use case and that as you pointed 
out we switched it multiple times, there shouldn't be much problems with 
this. I rather be unable to detach guestfwd than come up with some 
complicated changes to our code just to allow it for domains started 
with older libvirt.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.