storagepoolxml2argvtest: delete some lines

[libvirt] [PATCH 0/3] storagepoolxml2argvtest: delete some lines

Posted by Ján Tomko 5 years, 2 months ago

Also fix the build on FreeBSD

Ján Tomko (3):
  storagepoolxml2argvtest: pass the platform suffix as a string
  storagepoolxml2argvtest: introduce DO_TEST_PLATFORM
  storagepoolxml2argvtest: run mountopts test conditionally

 tests/storagepoolxml2argvtest.c | 76 +++++++++++++++--------------------------
 1 file changed, 28 insertions(+), 48 deletions(-)

-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] storagepoolxml2argvtest: delete some lines

Posted by Andrea Bolognani 5 years, 2 months ago

On Thu, 2019-01-31 at 15:54 +0100, Ján Tomko wrote:
> Also fix the build on FreeBSD
> 
> Ján Tomko (3):
>   storagepoolxml2argvtest: pass the platform suffix as a string
>   storagepoolxml2argvtest: introduce DO_TEST_PLATFORM
>   storagepoolxml2argvtest: run mountopts test conditionally
> 
>  tests/storagepoolxml2argvtest.c | 76 +++++++++++++++--------------------------
>  1 file changed, 28 insertions(+), 48 deletions(-)

I love it.

Assuming you have compile-tested the series on the relevant
platforms, which I can't really be bothered doing right now, you
can sprinkle it with some

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and push away.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] storagepoolxml2argvtest: delete some lines

Posted by Roman Bogorodskiy 5 years, 2 months ago

  Andrea Bolognani wrote:

> On Thu, 2019-01-31 at 15:54 +0100, Ján Tomko wrote:
> > Also fix the build on FreeBSD
> > 
> > Ján Tomko (3):
> >   storagepoolxml2argvtest: pass the platform suffix as a string
> >   storagepoolxml2argvtest: introduce DO_TEST_PLATFORM
> >   storagepoolxml2argvtest: run mountopts test conditionally
> > 
> >  tests/storagepoolxml2argvtest.c | 76 +++++++++++++++--------------------------
> >  1 file changed, 28 insertions(+), 48 deletions(-)
> 
> I love it.
> 
> Assuming you have compile-tested the series on the relevant
> platforms, which I can't really be bothered doing right now, you
> can sprinkle it with some
> 
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> and push away.
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization

FWIW, make check passes on FreeBSD with this series applied.

Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list