[libvirt] [PATCH 3/3] domain_conf: Free egl render node in virDomainGraphicsDefFree

Michal Privoznik posted 3 patches 5 years, 10 months ago
There is a newer version of this series
[libvirt] [PATCH 3/3] domain_conf: Free egl render node in virDomainGraphicsDefFree
Posted by Michal Privoznik 5 years, 10 months ago
 13 bytes in 1 blocks are definitely lost in loss record 44 of 179
    at 0x4C2EE6F: malloc (vg_replace_malloc.c:299)
    by 0x9514A69: strdup (in /lib64/libc-2.27.so)
    by 0x5E60C0B: virStrdup (virstring.c:956)
    by 0x54C856F: virHostGetDRMRenderNode (qemuxml2argvmock.c:190)
    by 0x57CB4E3: qemuProcessGraphicsSetupRenderNode (qemu_process.c:4860)
    by 0x57CB571: qemuProcessSetupGraphics (qemu_process.c:4881)
    by 0x57CE01B: qemuProcessPrepareDomain (qemu_process.c:6040)
    by 0x57D102E: qemuProcessCreatePretendCmd (qemu_process.c:6975)
    by 0x114C1C: testCompareXMLToArgv (qemuxml2argvtest.c:611)
    by 0x134B90: virTestRun (testutils.c:174)
    by 0x123478: mymain (qemuxml2argvtest.c:1697)
    by 0x136BFA: virTestMain (testutils.c:1112)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/conf/domain_conf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 54d6364f4f..f3d541bc12 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1423,6 +1423,9 @@ void virDomainGraphicsDefFree(virDomainGraphicsDefPtr def)
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_EGL_HEADLESS:
+        VIR_FREE(def->data.egl_headless.rendernode);
+        break;
+
     case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
         break;
     }
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/3] domain_conf: Free egl render node in virDomainGraphicsDefFree
Posted by Erik Skultety 5 years, 10 months ago
On Wed, Jan 23, 2019 at 04:45:08PM +0100, Michal Privoznik wrote:
>  13 bytes in 1 blocks are definitely lost in loss record 44 of 179
>     at 0x4C2EE6F: malloc (vg_replace_malloc.c:299)
>     by 0x9514A69: strdup (in /lib64/libc-2.27.so)
>     by 0x5E60C0B: virStrdup (virstring.c:956)
>     by 0x54C856F: virHostGetDRMRenderNode (qemuxml2argvmock.c:190)
>     by 0x57CB4E3: qemuProcessGraphicsSetupRenderNode (qemu_process.c:4860)
>     by 0x57CB571: qemuProcessSetupGraphics (qemu_process.c:4881)
>     by 0x57CE01B: qemuProcessPrepareDomain (qemu_process.c:6040)
>     by 0x57D102E: qemuProcessCreatePretendCmd (qemu_process.c:6975)
>     by 0x114C1C: testCompareXMLToArgv (qemuxml2argvtest.c:611)
>     by 0x134B90: virTestRun (testutils.c:174)
>     by 0x123478: mymain (qemuxml2argvtest.c:1697)
>     by 0x136BFA: virTestMain (testutils.c:1112)
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list