qemu: Don't format 'cache' for empty cdroms

[libvirt] [PATCH 0/2] qemu: Don't format 'cache' for empty cdroms

Peter Krempa posted 2 patches 5 years, 3 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1547631699.git.pkrempa@redhat.com

src/qemu/qemu_command.c                       | 47 ++++++++++---------
tests/qemuxml2argvdata/disk-cdrom.args        |  6 ++-
.../disk-cdrom.x86_64-2.12.0.args             |  9 ++--
.../disk-cdrom.x86_64-latest.args             |  9 ++--
tests/qemuxml2argvdata/disk-cdrom.xml         |  6 +++
tests/qemuxml2xmloutdata/disk-cdrom.xml       |  6 +++
6 files changed, 52 insertions(+), 31 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] qemu: Don't format 'cache' for empty cdroms

Posted by Peter Krempa 5 years, 3 months ago

See patch 2/2 for explanation.

Peter Krempa (2):
  tests: qemuxml2argv: Add test case for empty CDROM with cache mode
  qemu: command: Don't format image properties for empty -drive

 src/qemu/qemu_command.c                       | 47 ++++++++++---------
 tests/qemuxml2argvdata/disk-cdrom.args        |  6 ++-
 .../disk-cdrom.x86_64-2.12.0.args             |  9 ++--
 .../disk-cdrom.x86_64-latest.args             |  9 ++--
 tests/qemuxml2argvdata/disk-cdrom.xml         |  6 +++
 tests/qemuxml2xmloutdata/disk-cdrom.xml       |  6 +++
 6 files changed, 52 insertions(+), 31 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] qemu: Don't format 'cache' for empty cdroms

Posted by Ján Tomko 5 years, 3 months ago

On Wed, Jan 16, 2019 at 10:42:08AM +0100, Peter Krempa wrote:
>See patch 2/2 for explanation.
>
>Peter Krempa (2):
>  tests: qemuxml2argv: Add test case for empty CDROM with cache mode
>  qemu: command: Don't format image properties for empty -drive
>
> src/qemu/qemu_command.c                       | 47 ++++++++++---------
> tests/qemuxml2argvdata/disk-cdrom.args        |  6 ++-
> .../disk-cdrom.x86_64-2.12.0.args             |  9 ++--
> .../disk-cdrom.x86_64-latest.args             |  9 ++--
> tests/qemuxml2argvdata/disk-cdrom.xml         |  6 +++
> tests/qemuxml2xmloutdata/disk-cdrom.xml       |  6 +++
> 6 files changed, 52 insertions(+), 31 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list