[v1] qemu: Fix offline migration onto the same host

[libvirt] [PATCH 0/4] qemu: Fix offline migration onto the same host

Michal Privoznik posted 4 patches 5 years, 4 months ago

Diff against v2
Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1542892462.git.mprivozn@redhat.com

There is a newer version of this series

src/qemu/qemu_migration.c        | 42 ++++++++++++++++++++------------
src/qemu/qemu_migration_cookie.c | 23 ++++++++---------
src/qemu/qemu_migration_cookie.h |  4 ++-
3 files changed, 41 insertions(+), 28 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] qemu: Fix offline migration onto the same host

Posted by Michal Privoznik 5 years, 4 months ago

This started as a report on #virt that the following command makes
libvirt lose domain and which is worse - remove its XML!

  virsh migrate --offline --undefinesource --persistent $dom qemu+tcp://localhost/system

Turns out, there are two problems. The first one is that we try to add
incoming domain definition onto virDomainObjList before parsing
migration cookie; the second one being VIR_MIGRATE_UNDEFINE_SOURCE takes
effect regardless of migration success or failure.

Michal Prívozník (4):
  qemuMigrationDstPrepareAny: Don't overwrite error in cleanup path
  qemuMigrationEatCookie: Pass virDomainDef instead of virDomainObj
  qemuMigrationDstPrepareAny: Parse cookie before adding domain onto
    list
  qemuMigrationSrcConfirm: Don't remove domain config if confirm phase
    fails

 src/qemu/qemu_migration.c        | 42 ++++++++++++++++++++------------
 src/qemu/qemu_migration_cookie.c | 23 ++++++++---------
 src/qemu/qemu_migration_cookie.h |  4 ++-
 3 files changed, 41 insertions(+), 28 deletions(-)

-- 
2.18.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list