conf: Forbid some nonsensical combinations under <memoryBackend>

[libvirt] [PATCH 0/2] conf: Forbid some nonsensical combinations under <memoryBackend>

Michal Privoznik posted 2 patches 5 years, 6 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1539607126.git.mprivozn@redhat.com

Test syntax-check passed

src/conf/domain_conf.c                        | 25 +++++++++++++++++--
.../qemuxml2argvdata/hugepages-memaccess2.xml |  1 -
2 files changed, 23 insertions(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] conf: Forbid some nonsensical combinations under <memoryBackend>

Posted by Michal Privoznik 5 years, 6 months ago

*** BLURB HERE ***

Michal Prívozník (2):
  conf: Forbid hugepages and <source type='file'/>
  conf: Forbid hugepages and <allocation mode="ondemand"/>

 src/conf/domain_conf.c                        | 25 +++++++++++++++++--
 .../qemuxml2argvdata/hugepages-memaccess2.xml |  1 -
 2 files changed, 23 insertions(+), 3 deletions(-)

-- 
2.18.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: Forbid some nonsensical combinations under <memoryBackend>

Posted by John Ferlan 5 years, 5 months ago

On 10/15/18 8:39 AM, Michal Privoznik wrote:
> *** BLURB HERE ***
> 
> Michal Prívozník (2):
>   conf: Forbid hugepages and <source type='file'/>
>   conf: Forbid hugepages and <allocation mode="ondemand"/>
> 
>  src/conf/domain_conf.c                        | 25 +++++++++++++++++--
>  .../qemuxml2argvdata/hugepages-memaccess2.xml |  1 -
>  2 files changed, 23 insertions(+), 3 deletions(-)
> 

It wasn't clear from the existing review comment whether you were going
to update; however, the one thing I'd point out is that by changing Post
Parse processing to add some XML check/condition that was previously
accepted could theoretically cause a guest to disappear after libvirtd
restart, right?

Thus shouldn't the changes go in the Validate processing?

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list