qemu: Fix disk hotplug/media change regression

[libvirt] [PATCH 0/8] qemu: Fix disk hotplug/media change regression

Peter Krempa posted 8 patches 5 years, 7 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1538060882.git.pkrempa@redhat.com

Test syntax-check passed

src/qemu/qemu_conf.c    |   2 +-
src/qemu/qemu_conf.h    |   5 ++
src/qemu/qemu_driver.c  |   7 +-
src/qemu/qemu_hotplug.c | 188 ++++++++++++++++++++++------------------
src/qemu/qemu_hotplug.h |   9 +-
tests/qemuhotplugtest.c |   2 +-
6 files changed, 123 insertions(+), 90 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/8] qemu: Fix disk hotplug/media change regression

Posted by Peter Krempa 5 years, 7 months ago

Few of my recent patches (see the first two reverts) introduced a
regression when adding disks. The disk alias is needed when creating
names of certain backend objects (secrets/TLS). The code preparing those
was moved prior to alias formatting.

Revert those patches and fix it in a different way.

Peter Krempa (8):
  Revert "qemu: hotplug: Prepare disk source in
    qemuDomainAttachDeviceDiskLive"
  Revert "qemu: hotplug: consolidate media change code paths"
  qemu: hotplug: Use new source when preparing/translating for media
    change
  qemu: hotplug: Prepare disk source for media changing
  qemu: hotplug: Add wrapper for disk hotplug code
  qemu: conf: Export qemuAddSharedDisk
  qemu: hotplug: Split out media change code from disk hotplug
  qemu: hotplug: Refactor qemuDomainAttachDeviceDiskLiveInternal

 src/qemu/qemu_conf.c    |   2 +-
 src/qemu/qemu_conf.h    |   5 ++
 src/qemu/qemu_driver.c  |   7 +-
 src/qemu/qemu_hotplug.c | 188 ++++++++++++++++++++++------------------
 src/qemu/qemu_hotplug.h |   9 +-
 tests/qemuhotplugtest.c |   2 +-
 6 files changed, 123 insertions(+), 90 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list