[libvirt] [PATCH 7/7] configure: remove regexec and getgrnam_r checks

Ján Tomko posted 7 patches 7 years, 4 months ago
[libvirt] [PATCH 7/7] configure: remove regexec and getgrnam_r checks
Posted by Ján Tomko 7 years, 4 months ago
Introduced by:
commit 635ae38979bbb2659a21dfaa57e7c762ae8d4e88
commit 1b745219c7507595d4a09c89aa6a331eaa039e31
But their HAVE_ counterparts were never used.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 configure.ac | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 89bb6f86fc..39600017ab 100644
--- a/configure.ac
+++ b/configure.ac
@@ -327,7 +327,6 @@ AC_CHECK_FUNCS_ONCE([\
   fallocate \
   geteuid \
   getgid \
-  getgrnam_r \
   getmntent_r \
   getpwuid_r \
   getrlimit \
@@ -338,7 +337,6 @@ AC_CHECK_FUNCS_ONCE([\
   posix_fallocate \
   posix_memalign \
   prlimit \
-  regexec \
   sched_getaffinity \
   setgroups \
   setns \
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 7/7] configure: remove regexec and getgrnam_r checks
Posted by Erik Skultety 7 years, 4 months ago
On Tue, Sep 25, 2018 at 05:23:50PM +0200, Ján Tomko wrote:
> Introduced by:
> commit 635ae38979bbb2659a21dfaa57e7c762ae8d4e88
> commit 1b745219c7507595d4a09c89aa6a331eaa039e31
> But their HAVE_ counterparts were never used.

Especially the regexec part wasn't clear from the corresponding commit message,
well, ancient dark times where commit messages didn't need to be split and
commit messages didn't need to contain any description whatsoever.

Looks reasonable to me, I can't run this on my builders at the moment to check
whether all the platforms are happy, but that's why we've got CI.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list