[libvirt] [PATCH 2/7] configure: sort AC_CHECK_HEADERS argument list

Ján Tomko posted 7 patches 7 years, 4 months ago
[libvirt] [PATCH 2/7] configure: sort AC_CHECK_HEADERS argument list
Posted by Ján Tomko 7 years, 4 months ago
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 configure.ac | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/configure.ac b/configure.ac
index f23faf8b8f..00e2de7b1f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -353,23 +353,23 @@ AC_CHECK_FUNCS_ONCE([\
 
 dnl Availability of various common headers (non-fatal if missing).
 AC_CHECK_HEADERS([\
+  ifaddrs.h \
+  libtasn1.h \
+  linux/magic.h \
+  mntent.h \
+  net/ethernet.h \
+  netinet/tcp.h \
   pwd.h \
   regex.h \
-  sys/un.h \
-  sys/poll.h \
+  stdarg.h \
   syslog.h \
-  mntent.h \
-  net/ethernet.h \
-  linux/magic.h \
-  sys/un.h \
+  sys/mount.h \
+  sys/poll.h \
   sys/syscall.h \
   sys/sysctl.h \
-  netinet/tcp.h \
-  ifaddrs.h \
-  libtasn1.h \
   sys/ucred.h \
-  sys/mount.h \
-  stdarg.h \
+  sys/un.h \
+  sys/un.h \
   ])
 dnl Check whether endian provides handy macros.
 AC_CHECK_DECLS([htole64], [], [], [[#include <endian.h>]])
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/7] configure: sort AC_CHECK_HEADERS argument list
Posted by Erik Skultety 7 years, 4 months ago
On Tue, Sep 25, 2018 at 05:23:45PM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  configure.ac | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index f23faf8b8f..00e2de7b1f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -353,23 +353,23 @@ AC_CHECK_FUNCS_ONCE([\

Since you're doing this kind of stuff already, I'd like to keep it consistent
and have the FUNCS_ONCE sorted too.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list