On Tue, Sep 11, 2018 at 06:32:29PM -0400, Jeff Cody wrote:
> Changes from v3:
> ================
>
> Patch 4: Typo fixed [Eric]
> Added examples [Eric]
>
> Changes from v2:
> =================
>
> Patch 4: New, document deprecation. [Eric]
> Patch 3,2: Add r-b's
>
>
> Changes from v1:
> =================
>
> Patch 1: Don't pass unused BlockDriverState to helper function
>
> Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric]
> Add deprecation warning [John]
> Pull legacy parsing code into function [John]
> Fixed filename leak
>
> Patch 3: New; iotest 231. [Eric]
>
>
> iotest failure on current master:
>
> QA output created by 231
> -qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated. Future versions may cease to parse these options in the future.
> -unable to get monitor info from DNS SRV with service name: ceph-mon
> -no monitors specified to connect to.
> -qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory
> +qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': Parameter 'pool' is missing
> unable to get monitor info from DNS SRV with service name: ceph-mon
> no monitors specified to connect to.
> qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory
> Failures: 231
> Failed 1 of 1 tests
>
> Jeff Cody (4):
> block/rbd: pull out qemu_rbd_convert_options
> block/rbd: Attempt to parse legacy filenames
> block/rbd: add iotest for rbd legacy keyvalue filename parsing
> block/rbd: add deprecation documentation for filename keyvalue pairs
>
> block/rbd.c | 89 ++++++++++++++++++++++++++++++++------
> qemu-deprecated.texi | 15 +++++++
> tests/qemu-iotests/231 | 62 ++++++++++++++++++++++++++
> tests/qemu-iotests/231.out | 9 ++++
> tests/qemu-iotests/group | 1 +
> 5 files changed, 162 insertions(+), 14 deletions(-)
> create mode 100755 tests/qemu-iotests/231
> create mode 100644 tests/qemu-iotests/231.out
>
> --
> 2.17.1
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff