[libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest

Peter Krempa posted 4 patches 7 years, 5 months ago
[libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest
Posted by Peter Krempa 7 years, 5 months ago
'metadata' and 'leases' are features internal to libvirt and thus don't
influence the XML. As they are not tested we don't need the output
files.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuxml2argvdata/lease.args    | 23 -----------------------
 tests/qemuxml2argvdata/metadata.args | 22 ----------------------
 2 files changed, 45 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/lease.args
 delete mode 100644 tests/qemuxml2argvdata/metadata.args

diff --git a/tests/qemuxml2argvdata/lease.args b/tests/qemuxml2argvdata/lease.args
deleted file mode 100644
index 000538b67e..0000000000
--- a/tests/qemuxml2argvdata/lease.args
+++ /dev/null
@@ -1,23 +0,0 @@
-LC_ALL=C \
-PATH=/bin \
-HOME=/home/test \
-USER=test \
-LOGNAME=test \
-QEMU_AUDIO_DRV=none \
-/usr/bin/qemu-system-i686 \
--name QEMUGuest1 \
--S \
--M pc \
--m 214 \
--smp 1 \
--uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
--nographic \
--monitor unix:/tmp/test-monitor,server,nowait \
--no-acpi \
--boot c \
--usb \
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=ide,bus=0,unit=0 \
--cdrom /root/boot.iso \
--net none \
--serial none \
--parallel none
diff --git a/tests/qemuxml2argvdata/metadata.args b/tests/qemuxml2argvdata/metadata.args
deleted file mode 100644
index 1fb74e47fa..0000000000
--- a/tests/qemuxml2argvdata/metadata.args
+++ /dev/null
@@ -1,22 +0,0 @@
-LC_ALL=C \
-PATH=/bin \
-HOME=/home/test \
-USER=test \
-LOGNAME=test \
-QEMU_AUDIO_DRV=none \
-/usr/bin/qemu-system-i686 \
--name QEMUGuest1 \
--S \
--M pc \
--m 214 \
--smp 1 \
--uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
--nographic \
--monitor unix:/tmp/test-monitor,server,nowait \
--no-acpi \
--boot c \
--usb \
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=ide,bus=0,unit=0 \
--net none \
--serial none \
--parallel none
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest
Posted by Erik Skultety 7 years, 5 months ago
On Mon, Aug 27, 2018 at 06:09:09PM +0200, Peter Krempa wrote:
> 'metadata' and 'leases' are features internal to libvirt and thus don't
> influence the XML. As they are not tested we don't need the output
> files.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] tests: qemuxml2argv: Remove 'args' for tests only used in xml2xmltest
Posted by Andrea Bolognani 7 years, 5 months ago
On Mon, 2018-08-27 at 18:09 +0200, Peter Krempa wrote:
> 'metadata' and 'leases' are features internal to libvirt and thus don't
> influence the XML. As they are not tested we don't need the output
> files.

I think you meant s/XML/generated QEMU command line/ here?

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list