[v3] Introduce metadata locking

[libvirt] [PATCH v3 05/28] virLockManagerLockDaemonAcquire: Drop useless check

Posted by Michal Privoznik 7 years, 5 months ago

The if() is completely useless since args.path is set to NULL in
the line just above.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/locking/lock_driver_lockd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c
index 2386b24f40..2574cd47e2 100644
--- a/src/locking/lock_driver_lockd.c
+++ b/src/locking/lock_driver_lockd.c
@@ -650,8 +650,7 @@ static int virLockManagerLockDaemonAcquire(virLockManagerPtr lock,
 
             memset(&args, 0, sizeof(args));
 
-            if (priv->resources[i].lockspace)
-                args.path = priv->resources[i].lockspace;
+            args.path = priv->resources[i].lockspace;
             args.name = priv->resources[i].name;
             args.flags = priv->resources[i].flags;
 
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 05/28] virLockManagerLockDaemonAcquire: Drop useless check

Posted by John Ferlan 7 years, 5 months ago


On 08/27/2018 04:08 AM, Michal Privoznik wrote:
> The if() is completely useless since args.path is set to NULL in
> the line just above.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/locking/lock_driver_lockd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list