[libvirt] [PATCH v3 26/28] security_dac: Fix const correctness

Michal Privoznik posted 28 patches 7 years, 5 months ago
There is a newer version of this series
[libvirt] [PATCH v3 26/28] security_dac: Fix const correctness
Posted by Michal Privoznik 7 years, 5 months ago
These two functions (virSecurityDACSetOwnership and
virSecurityDACRestoreFileLabelInternal) do not really change
@src. Make it const.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/security/security_dac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 1be4ead21c..7528d8ba7d 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -624,7 +624,7 @@ virSecurityDACSetOwnershipInternal(const virSecurityDACData *priv,
 
 static int
 virSecurityDACSetOwnership(virSecurityManagerPtr mgr,
-                           virStorageSourcePtr src,
+                           const virStorageSource *src,
                            const char *path,
                            uid_t uid,
                            gid_t gid)
@@ -655,7 +655,7 @@ virSecurityDACSetOwnership(virSecurityManagerPtr mgr,
 
 static int
 virSecurityDACRestoreFileLabelInternal(virSecurityManagerPtr mgr,
-                                       virStorageSourcePtr src,
+                                       const virStorageSource *src,
                                        const char *path)
 {
     virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 26/28] security_dac: Fix const correctness
Posted by John Ferlan 7 years, 5 months ago

On 08/27/2018 04:08 AM, Michal Privoznik wrote:
> These two functions (virSecurityDACSetOwnership and
> virSecurityDACRestoreFileLabelInternal) do not really change
> @src. Make it const.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/security/security_dac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list