[v1] Fix a SIGSEGV in libvirtd when querying AMD SEV info

[libvirt] [PATCH 0/4] Fix a SIGSEGV in libvirtd when querying AMD SEV info

Erik Skultety posted 4 patches 5 years, 8 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1534344913.git.eskultet@redhat.com

Test syntax-check passed

There is a newer version of this series

src/conf/domain_capabilities.h                     |   4 +
src/qemu/qemu_capabilities.c                       | 112 +++++++++++++++++++--
src/qemu/qemu_monitor_json.c                       |  20 ++--
tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml  |   5 +-
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |   6 ++
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |   1 -
...args => launch-security-sev.x86_64-2.12.0.args} |  19 ++--
tests/qemuxml2argvtest.c                           |   4 +-
8 files changed, 142 insertions(+), 29 deletions(-)
rename tests/qemuxml2argvdata/{launch-security-sev.args => launch-security-sev.x86_64-2.12.0.args} (54%)

Expand all Fold all

[libvirt] [PATCH 0/4] Fix a SIGSEGV in libvirtd when querying AMD SEV info

Posted by Erik Skultety 5 years, 8 months ago

This series fixes the following BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1612009

TL;DR:
We don't format SEV platform data (PDH, certificate chain,...) into our qemu
caps cache which poses a problem after libvirtd restart when we restore from
the cache and get a segfault upon issuing virNodeGetSEVInfo.

I performed some tests on an AMD machine, but CC'ing Brijesh, he might give it
a test too.

Erik Skultety (4):
  tests: sev: Test launch-security with specific QEMU version
  qemu: Define and use a auto cleanup function with virSEVCapability
  qemu: Fix probing of AMD SEV support
  qemu: caps: Format SEV platform data into qemuCaps cache

 src/conf/domain_capabilities.h                     |   4 +
 src/qemu/qemu_capabilities.c                       | 112 +++++++++++++++++++--
 src/qemu/qemu_monitor_json.c                       |  20 ++--
 tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml  |   5 +-
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |   6 ++
 tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |   1 -
 ...args => launch-security-sev.x86_64-2.12.0.args} |  19 ++--
 tests/qemuxml2argvtest.c                           |   4 +-
 8 files changed, 142 insertions(+), 29 deletions(-)
 rename tests/qemuxml2argvdata/{launch-security-sev.args => launch-security-sev.x86_64-2.12.0.args} (54%)

--
2.14.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Fix a SIGSEGV in libvirtd when querying AMD SEV info

Posted by Brijesh Singh 5 years, 8 months ago

Hi Erik,

On 08/15/2018 10:02 AM, Erik Skultety wrote:
> This series fixes the following BZ:
> https://bugzilla.redhat.com/show_bug.cgi?id=1612009
> 
> TL;DR:
> We don't format SEV platform data (PDH, certificate chain,...) into our qemu
> caps cache which poses a problem after libvirtd restart when we restore from
> the cache and get a segfault upon issuing virNodeGetSEVInfo.
> 
> I performed some tests on an AMD machine, but CC'ing Brijesh, he might give it
> a test too.
> 

I tested this series on my EPYC system (which supports SEV) and
everything seems to be working fine. I have verified the below
code snippet from BZ

import libvirt
conn = libvirt.open()
conn.getSEVInfo()

And I can confirm that getSEVInfo is able to get the PDH certificates etc.

Tested-by: Brijesh Singh <brijesh.singh@amd.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list