[v1] qemu: Add support for -blockdev

[libvirt] [PATCH RFC 08/39] util: virqemu: Simplify debugging if building QOM object with missing args

Posted by Peter Krempa 7 years, 6 months ago

Print the values so it's simpler to debug.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virqemu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/util/virqemu.c b/src/util/virqemu.c
index 30b8dc18d4..7ffa9f780e 100644
--- a/src/util/virqemu.c
+++ b/src/util/virqemu.c
@@ -248,8 +248,9 @@ virQEMUBuildObjectCommandlineFromJSONInternal(virBufferPtr buf,
                                               virJSONValuePtr props)
 {
     if (!type || !alias) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("missing 'type' or 'alias' field of QOM 'object'"));
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("missing 'type'(%s) or 'alias'(%s) field of QOM 'object'"),
+                       NULLSTR(type), NULLSTR(alias));
         return -1;
     }

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 08/39] util: virqemu: Simplify debugging if building QOM object with missing args

Posted by Ján Tomko 7 years, 6 months ago

On Wed, Jul 25, 2018 at 05:57:39PM +0200, Peter Krempa wrote:
>Print the values so it's simpler to debug.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/util/virqemu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list