[libvirt] [PATCH RFC 09/39] qemu: caps: Add capability for using the blockdev infrastructure

Peter Krempa posted 39 patches 7 years, 6 months ago
There is a newer version of this series
[libvirt] [PATCH RFC 09/39] qemu: caps: Add capability for using the blockdev infrastructure
Posted by Peter Krempa 7 years, 6 months ago
The capability currently is not enabled so that we can add individual
bits first.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_capabilities.c | 1 +
 src/qemu/qemu_capabilities.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 0fb800589a..6b4c14ac50 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -507,6 +507,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,

               /* 315 */
               "vfio-pci.display",
+              "blockdev",
     );


diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 9e8ad5f5c3..452761e672 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -491,6 +491,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */

     /* 315 */
     QEMU_CAPS_VFIO_PCI_DISPLAY, /* -device vfio-pci.display */
+    QEMU_CAPS_BLOCKDEV, /* -blockdev and blockdev-add are supported */

     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH RFC 09/39] qemu: caps: Add capability for using the blockdev infrastructure
Posted by Ján Tomko 7 years, 6 months ago
On Wed, Jul 25, 2018 at 05:57:40PM +0200, Peter Krempa wrote:
>The capability currently is not enabled so that we can add individual
>bits first.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_capabilities.c | 1 +
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 2 insertions(+)
>

I guess even if you pushed this along with the commit actually enabling
this, having this stub here helps with separating all the changes while
maintaining bisectability.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list