[libvirt] [PATCH 4/6] tests: qemumonitorjson: Raise the necessary debug level for QAPI schema checks

Peter Krempa posted 6 patches 7 years, 6 months ago
[libvirt] [PATCH 4/6] tests: qemumonitorjson: Raise the necessary debug level for QAPI schema checks
Posted by Peter Krempa 7 years, 6 months ago
The debug output of the schema validator on success is not so
interresting that it should be printed when basic debugging is enabled.

Print it only when test debugging is set to 3 and more.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemumonitorjsontest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 9039cef423..fce2108932 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -2838,7 +2838,7 @@ testQAPISchema(const void *opaque)
         ret = 0;
     }

-    if (virTestGetDebug() ||
+    if (virTestGetDebug() >= 3 ||
         (ret < 0 && virTestGetVerbose())) {
         char *debugstr = virBufferContentAndReset(&debug);
         fprintf(stderr, "\n%s\n", debugstr);
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/6] tests: qemumonitorjson: Raise the necessary debug level for QAPI schema checks
Posted by Ján Tomko 7 years, 6 months ago
On Thu, Jul 12, 2018 at 01:58:42PM +0200, Peter Krempa wrote:
>The debug output of the schema validator on success is not so
>interresting that it should be printed when basic debugging is enabled.
>

*interesting

>Print it only when test debugging is set to 3 and more.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tests/qemumonitorjsontest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list