qemu: Disk-related cleanups a refactors

[libvirt] [PATCH 5/9] qemu: hotplug: Add warning regarding SD hotplug

Posted by Peter Krempa 7 years, 7 months ago

SD card hotplug should not be implemented until they can be used via
-blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_hotplug.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 23f6d1daba..69f599f575 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -725,6 +725,9 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
         case VIR_DOMAIN_DISK_BUS_UML:
         case VIR_DOMAIN_DISK_BUS_SATA:
         case VIR_DOMAIN_DISK_BUS_SD:
+            /* Note that SD card hotplug support should be added only once
+             * they support '-device' (don't require -drive only).
+             * See also: qemuDiskBusNeedsDriveArg */
         case VIR_DOMAIN_DISK_BUS_LAST:
             virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                            _("disk bus '%s' cannot be hotplugged."),
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 5/9] qemu: hotplug: Add warning regarding SD hotplug

Posted by Ján Tomko 7 years, 7 months ago

On Tue, Jul 10, 2018 at 10:44:45AM +0200, Peter Krempa wrote:
>SD card hotplug should not be implemented until they can be used via
>-blockdev.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_hotplug.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list