Implement Interface APIs

[libvirt] [dbus PATCH 04/15] Implement Active property for Interface Interface

Posted by Anya Harter 7 years, 7 months ago

Signed-off-by: Anya Harter <aharter@redhat.com>
---
 data/org.libvirt.Interface.xml |  4 ++++
 src/interface.c                | 22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index e6d9f2a..f50bc37 100644
--- a/data/org.libvirt.Interface.xml
+++ b/data/org.libvirt.Interface.xml
@@ -13,5 +13,9 @@
         value="See https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceGetMACString"/>
       <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="const"/>
     </property>
+    <property name="Active" type="b" access="read">
+      <annotation name="org.gtk.GDBus.DocString"
+        value="See https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceIsActive"/>
+    </property>
   </interface>
 </node>
diff --git a/src/interface.c b/src/interface.c
index 2b62304..b73e116 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -66,7 +66,29 @@ virtDBusInterfaceGetMACString(const gchar *objectPath,
     *value = g_variant_new("s", mac);
 }
 
+static void
+virtDBusInterfaceGetActive(const gchar *objectPath,
+                           gpointer userData,
+                           GVariant **value,
+                           GError **error)
+{
+    virtDBusConnect *connect = userData;
+    g_autoptr(virInterface) interface = NULL;
+    gint active;
+
+    interface = virtDBusInterfaceGetVirInterface(connect, objectPath, error);
+    if (!interface)
+        return;
+
+    active = virInterfaceIsActive(interface);
+    if (active < 0)
+        return virtDBusUtilSetLastVirtError(error);
+
+    *value = g_variant_new("b", !!active);
+}
+
 static virtDBusGDBusPropertyTable virtDBusInterfacePropertyTable[] = {
+    { "Active", virtDBusInterfaceGetActive, NULL },
     { "MACString", virtDBusInterfaceGetMACString, NULL },
     { "Name", virtDBusInterfaceGetName, NULL },
     { 0 }
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 04/15] Implement Active property for Interface Interface

Posted by Pavel Hrdina 7 years, 7 months ago

On Fri, Jul 06, 2018 at 05:36:44PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter <aharter@redhat.com>
> ---
>  data/org.libvirt.Interface.xml |  4 ++++
>  src/interface.c                | 22 ++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
> index e6d9f2a..f50bc37 100644
> --- a/data/org.libvirt.Interface.xml
> +++ b/data/org.libvirt.Interface.xml
> @@ -13,5 +13,9 @@
>          value="See https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceGetMACString"/>
>        <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="const"/>
>      </property>
> +    <property name="Active" type="b" access="read">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceIsActive"/>
> +    </property>

There is no "org.freedesktop.DBus.Property.EmitsChangedSignal"
annotation and the default value is "true".  We need to change the
default value so there needs to be

<annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>

at the same level as <property ...> elements.

For example you can check "data/org.libvirt.Domain.xml".

Otherwise looks good.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list