[libvirt] [PATCH v2 08/10] viriscsitest: Move testSessionInfo struct

Michal Privoznik posted 10 patches 7 years, 7 months ago
[libvirt] [PATCH v2 08/10] viriscsitest: Move testSessionInfo struct
Posted by Michal Privoznik 7 years, 7 months ago
This struct has nothing to do with testIscsiadmCb() rather than
testISCSIGetSession(). Move it closer to the latter.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/viriscsitest.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/viriscsitest.c b/tests/viriscsitest.c
index a7287069ba..361bf6a8da 100644
--- a/tests/viriscsitest.c
+++ b/tests/viriscsitest.c
@@ -60,12 +60,6 @@ const char *iscsiadmSendtargetsOutput =
     "10.20.30.40:3260,1 iqn.2008-04.example:example1:iscsi.bar\n"
     "10.20.30.40:3260,1 iqn.2009-04.example:example1:iscsi.seven\n";
 
-struct testSessionInfo {
-    const char *device_path;
-    int output_version;
-    const char *expected_session;
-};
-
 static void testIscsiadmCb(const char *const*args,
                            const char *const*env ATTRIBUTE_UNUSED,
                            const char *input ATTRIBUTE_UNUSED,
@@ -109,6 +103,12 @@ static void testIscsiadmCb(const char *const*args,
     }
 }
 
+struct testSessionInfo {
+    const char *device_path;
+    int output_version;
+    const char *expected_session;
+};
+
 static int
 testISCSIGetSession(const void *data)
 {
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 08/10] viriscsitest: Move testSessionInfo struct
Posted by John Ferlan 7 years, 6 months ago

On 07/04/2018 05:23 AM, Michal Privoznik wrote:
> This struct has nothing to do with testIscsiadmCb() rather than
> testISCSIGetSession(). Move it closer to the latter.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tests/viriscsitest.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list