domain_addr: make functions static

[libvirt] [PATCH 0/4] domain_addr: make functions static

Anya Harter posted 4 patches 5 years, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1530648863.git.aharter@redhat.com

Test syntax-check passed

src/conf/domain_addr.c   | 197 +++++++++++++++++++--------------------
src/conf/domain_addr.h   |  39 --------
src/libvirt_private.syms |   8 --
3 files changed, 98 insertions(+), 146 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] domain_addr: make functions static

Posted by Anya Harter 5 years, 9 months ago

which are unused outside domain_addr.c

The commit where the last external use was removed is linked in each
commit when it exists

Anya Harter (4):
  domain_addr: make virDomainPCIAddressBusIsEmpty static
  domain_addr: make virDomainCCWAddress funcs static
  domain_addr: make virDomainVirtioSerialAddr funcs static
  domain_addr: make virDomainUSBAddressPortFormat static

 src/conf/domain_addr.c   | 197 +++++++++++++++++++--------------------
 src/conf/domain_addr.h   |  39 --------
 src/libvirt_private.syms |   8 --
 3 files changed, 98 insertions(+), 146 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] domain_addr: make functions static

Posted by Pavel Hrdina 5 years, 9 months ago

On Tue, Jul 03, 2018 at 04:19:47PM -0400, Anya Harter wrote:
> which are unused outside domain_addr.c
> 
> The commit where the last external use was removed is linked in each
> commit when it exists
> 
> Anya Harter (4):
>   domain_addr: make virDomainPCIAddressBusIsEmpty static
>   domain_addr: make virDomainCCWAddress funcs static
>   domain_addr: make virDomainVirtioSerialAddr funcs static
>   domain_addr: make virDomainUSBAddressPortFormat static

The patch 3 could be split into two commits, one that move the code and
second that manes function static.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com> and pushed.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list