[v1] viriscsi: Couple of fixes

[libvirt] [PATCH 0/5] viriscsi: Couple of fixes

Michal Privoznik posted 5 patches 5 years, 10 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1530284263.git.mprivozn@redhat.com

Test syntax-check passed

There is a newer version of this series

src/storage/storage_backend_iscsi.c |   5 +-
src/util/viriscsi.c                 | 197 +++++++++++++++++++++++-------------
src/util/viriscsi.h                 |   2 +
tests/viriscsitest.c                |   3 +-
4 files changed, 137 insertions(+), 70 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/5] viriscsi: Couple of fixes

Posted by Michal Privoznik 5 years, 10 months ago

I've noticed that I'm unable to start my iscsi pool if I put my
own IQN into the pool XML. This is very surprising because
iscsiadm would read it from initiatorname.conf file, right? Well,
no. If IQN is provided in pool XML the code calls slightly
different iscsiadm commands (e.g. to set up iSCSI interface) and
we don't pass the interface everywhere we should.

Michal Privoznik (5):
  virStorageBackendIQNFound: Fix ret value assignment
  virStorageBackendIQNFound: Rename out label
  virStorageBackendIQNFound: Rework iscsiadm output parsing
  virISCSIScanTargets: Honour iSCSI interface
  virISCSIScanTargets: Allow making targets persistent

 src/storage/storage_backend_iscsi.c |   5 +-
 src/util/viriscsi.c                 | 197 +++++++++++++++++++++++-------------
 src/util/viriscsi.h                 |   2 +
 tests/viriscsitest.c                |   3 +-
 4 files changed, 137 insertions(+), 70 deletions(-)

-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list