[libvirt] [PATCH 01/10] domaincaps: rename reduced-phys-bits to reducedPhysBits

Ján Tomko posted 10 patches 7 years, 8 months ago
[libvirt] [PATCH 01/10] domaincaps: rename reduced-phys-bits to reducedPhysBits
Posted by Ján Tomko 7 years, 8 months ago
We have enough elements using underscores instead of camelCase,
do not bring dashes into the mix.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 docs/formatdomaincaps.html.in  | 2 +-
 docs/schemas/domaincaps.rng    | 2 +-
 src/conf/domain_capabilities.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index 6be553a114..9920de4dac 100644
--- a/docs/formatdomaincaps.html.in
+++ b/docs/formatdomaincaps.html.in
@@ -492,7 +492,7 @@
       <dd>When memory encryption is enabled, one of the physical address bits
       (aka the C-bit) is utilized to mark if a memory page is protected. The
       C-bit position is Hypervisor dependent.</dd>
-      <dt><code>reduced-phys-bits</code></dt>
+      <dt><code>reducedPhysBits</code></dt>
       <dd>When memory encryption is enabled, we lose certain bits in physical
       address space. The number of bits we lose is hypervisor dependent.</dd>
     </dl>
diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
index 1d0a2e17aa..e25201fc68 100644
--- a/docs/schemas/domaincaps.rng
+++ b/docs/schemas/domaincaps.rng
@@ -216,7 +216,7 @@
       <element name='cbitpos'>
         <data type='unsignedInt'/>
       </element>
-      <element name='reduced-phys-bits'>
+      <element name='reducedPhysBits'>
         <data type='unsignedInt'/>
       </element>
     </element>
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index ec469bfb9a..e5d943af50 100644
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -565,7 +565,7 @@ virDomainCapsFeatureSEVFormat(virBufferPtr buf,
     virBufferAddLit(buf, "<sev supported='yes'>\n");
     virBufferAdjustIndent(buf, 2);
     virBufferAsprintf(buf, "<cbitpos>%d</cbitpos>\n", sev->cbitpos);
-    virBufferAsprintf(buf, "<reduced-phys-bits>%d</reduced-phys-bits>\n",
+    virBufferAsprintf(buf, "<reducedPhysBits>%d</reducedPhysBits>\n",
                           sev->reduced_phys_bits);
     virBufferAdjustIndent(buf, -2);
     virBufferAddLit(buf, "</sev>\n");
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 01/10] domaincaps: rename reduced-phys-bits to reducedPhysBits
Posted by Daniel P. Berrangé 7 years, 7 months ago
On Tue, Jun 12, 2018 at 02:00:15PM +0200, Ján Tomko wrote:
> We have enough elements using underscores instead of camelCase,
> do not bring dashes into the mix.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  docs/formatdomaincaps.html.in  | 2 +-
>  docs/schemas/domaincaps.rng    | 2 +-
>  src/conf/domain_capabilities.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list