[libvirt] [PATCH 04/10] remove virQEMUCapsSetSEVCapabilities

Ján Tomko posted 10 patches 7 years, 8 months ago
[libvirt] [PATCH 04/10] remove virQEMUCapsSetSEVCapabilities
Posted by Ján Tomko 7 years, 8 months ago
It is only used in one place.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_capabilities.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 35d46c465d..7131c2a8ee 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2084,16 +2084,6 @@ virQEMUCapsSetGICCapabilities(virQEMUCapsPtr qemuCaps,
 }
 
 
-void
-virQEMUCapsSetSEVCapabilities(virQEMUCapsPtr qemuCaps,
-                              virSEVCapability *capabilities)
-{
-    virSEVCapabilitiesFree(qemuCaps->sevCapabilities);
-
-    qemuCaps->sevCapabilities = capabilities;
-}
-
-
 virSEVCapabilityPtr
 virQEMUCapsGetSEVCapabilities(virQEMUCapsPtr qemuCaps)
 {
@@ -2697,8 +2687,8 @@ virQEMUCapsProbeQMPSEVCapabilities(virQEMUCapsPtr qemuCaps,
     if (qemuMonitorGetSEVCapabilities(mon, &caps) < 0)
         return -1;
 
-    virQEMUCapsSetSEVCapabilities(qemuCaps, caps);
-
+    virSEVCapabilitiesFree(qemuCaps->sevCapabilities);
+    qemuCaps->sevCapabilities = caps;
     return 0;
 }
 
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 04/10] remove virQEMUCapsSetSEVCapabilities
Posted by Daniel P. Berrangé 7 years, 7 months ago
On Tue, Jun 12, 2018 at 02:00:18PM +0200, Ján Tomko wrote:
> It is only used in one place.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list