[libvirt] [PATCH libvirt 0/3] events: clean up NULL checking involving virObjectEventStateQueueRemote

Anya Harter posted 3 patches 18 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1528741339.git.aharter@redhat.com
Test syntax-check passed
src/bhyve/bhyve_driver.c           | 15 ++----
src/conf/object_event.c            |  3 ++
src/lxc/lxc_driver.c               | 24 ++++------
src/lxc/lxc_process.c              |  9 ++--
src/network/bridge_driver.c        | 15 ++----
src/node_device/node_device_udev.c |  6 +--
src/qemu/qemu_domain.c             |  3 +-
src/remote/remote_driver.c         | 75 +++++++++++++-----------------
src/secret/secret_driver.c         |  9 ++--
src/storage/storage_driver.c       | 27 ++++-------
src/test/test_driver.c             |  3 --
src/vz/vz_sdk.c                    |  3 +-
12 files changed, 73 insertions(+), 119 deletions(-)

[libvirt] [PATCH libvirt 0/3] events: clean up NULL checking involving virObjectEventStateQueueRemote

Posted by Anya Harter 18 weeks ago
Currently, all virObjectEventStateQueue callers and
virObjectEventStateQueueRemote callers need to do NULL checking.

In this patch series, all NULL checking has been moved to 
virObjectEventStateQueueRemote and all callers of the Remote or 
not Remote function have their NULL checking removed.

Anya Harter (3):
  events: add NULL check in virObjectEventStateQueue
  events: move NULL check to EventStateQueueRemote
  events: remove remoteEventQueue wrapper function

 src/bhyve/bhyve_driver.c           | 15 ++----
 src/conf/object_event.c            |  3 ++
 src/lxc/lxc_driver.c               | 24 ++++------
 src/lxc/lxc_process.c              |  9 ++--
 src/network/bridge_driver.c        | 15 ++----
 src/node_device/node_device_udev.c |  6 +--
 src/qemu/qemu_domain.c             |  3 +-
 src/remote/remote_driver.c         | 75 +++++++++++++-----------------
 src/secret/secret_driver.c         |  9 ++--
 src/storage/storage_driver.c       | 27 ++++-------
 src/test/test_driver.c             |  3 --
 src/vz/vz_sdk.c                    |  3 +-
 12 files changed, 73 insertions(+), 119 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt 0/3] events: clean up NULL checking involving virObjectEventStateQueueRemote

Posted by Pavel Hrdina 18 weeks ago
On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
> Currently, all virObjectEventStateQueue callers and
> virObjectEventStateQueueRemote callers need to do NULL checking.
> 
> In this patch series, all NULL checking has been moved to 
> virObjectEventStateQueueRemote and all callers of the Remote or 
> not Remote function have their NULL checking removed.
> 
> Anya Harter (3):
>   events: add NULL check in virObjectEventStateQueue
>   events: move NULL check to EventStateQueueRemote
>   events: remove remoteEventQueue wrapper function

I've tweaked the commit messages and pushed it.  Congratulation on your
first libvirt contribution! :)

One note, the same cleanup as for remote driver can be done for test
driver and the testObjectEventQueue() function.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH libvirt 0/3] events: clean up NULL checking involving virObjectEventStateQueueRemote

Posted by Anya Harter 18 weeks ago

On 06/12/2018 01:36 AM, Pavel Hrdina wrote:
> On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
>> Currently, all virObjectEventStateQueue callers and
>> virObjectEventStateQueueRemote callers need to do NULL checking.
>>
>> In this patch series, all NULL checking has been moved to 
>> virObjectEventStateQueueRemote and all callers of the Remote or 
>> not Remote function have their NULL checking removed.
>>
>> Anya Harter (3):
>>   events: add NULL check in virObjectEventStateQueue
>>   events: move NULL check to EventStateQueueRemote
>>   events: remove remoteEventQueue wrapper function
> 
> I've tweaked the commit messages and pushed it.  Congratulation on your
> first libvirt contribution! :)


Thanks!
> 
> One note, the same cleanup as for remote driver can be done for test
> driver and the testObjectEventQueue() function.

Yes, my intent is to repeat this cleanup with testObjectEventQueue,
libxlDomainEventQueue, qemuDomainEventQueue, and umlDomainEventQueue.
I was going to send the four as a patch series once they were done.

This task was laid out on the BiteSizedTasks page
https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_EventStateQueue.


> 
> Pavel
> 
> 
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list