On 06/12/2018 01:36 AM, Pavel Hrdina wrote:
> On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
>> Currently, all virObjectEventStateQueue callers and
>> virObjectEventStateQueueRemote callers need to do NULL checking.
>>
>> In this patch series, all NULL checking has been moved to
>> virObjectEventStateQueueRemote and all callers of the Remote or
>> not Remote function have their NULL checking removed.
>>
>> Anya Harter (3):
>> events: add NULL check in virObjectEventStateQueue
>> events: move NULL check to EventStateQueueRemote
>> events: remove remoteEventQueue wrapper function
>
> I've tweaked the commit messages and pushed it. Congratulation on your
> first libvirt contribution! :)
Thanks!
>
> One note, the same cleanup as for remote driver can be done for test
> driver and the testObjectEventQueue() function.
Yes, my intent is to repeat this cleanup with testObjectEventQueue,
libxlDomainEventQueue, qemuDomainEventQueue, and umlDomainEventQueue.
I was going to send the four as a patch series once they were done.
This task was laid out on the BiteSizedTasks page
https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_EventStateQueue.
>
> Pavel
>
>
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list