[libvirt] [PATCH 1/2] qemu: free migEvent in qemuMigrationCapsCheck

Ján Tomko posted 2 patches 7 years, 8 months ago
[libvirt] [PATCH 1/2] qemu: free migEvent in qemuMigrationCapsCheck
Posted by Ján Tomko 7 years, 8 months ago
We allocate a temporary bitmap but never free it.

Introduced by <commit 1f8a1a9>:
    qemu: Do not use qemuMonitorSetMigrationCapability

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_migration_params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 578cd6671f..2083563d32 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -1343,6 +1343,7 @@ qemuMigrationCapsCheck(virQEMUDriverPtr driver,
     ret = 0;
 
  cleanup:
+    virBitmapFree(migEvent);
     virJSONValueFree(json);
     virStringListFree(caps);
     return ret;
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/2] qemu: free migEvent in qemuMigrationCapsCheck
Posted by Peter Krempa 7 years, 8 months ago
On Wed, May 30, 2018 at 16:08:06 +0200, Ján Tomko wrote:
> We allocate a temporary bitmap but never free it.
> 
> Introduced by <commit 1f8a1a9>:
>     qemu: Do not use qemuMonitorSetMigrationCapability
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_migration_params.c | 1 +
>  1 file changed, 1 insertion(+)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list