GnuTLS fixes and requirements

[libvirt] [PATCH 0/8] GnuTLS fixes and requirements

Ján Tomko posted 8 patches 5 years, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1526385621.git.jtomko@redhat.com

Test syntax-check passed

config-post.h              |  2 --
m4/virt-gnutls.m4          | 50 +++-------------------------
src/libvirt.c              | 83 ----------------------------------------------
src/rpc/virnettlscontext.c |  4 +--
src/util/vircrypto.c       | 28 ++++++++--------
src/util/vircrypto.h       |  2 +-
tests/qemuxml2argvtest.c   |  8 ++---
tests/vircryptotest.c      | 26 ++++++++++-----
tests/virfilecachetest.c   | 19 ++++++++---
9 files changed, 58 insertions(+), 164 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/8] GnuTLS fixes and requirements

Posted by Ján Tomko 5 years, 11 months ago

The first two patches fix the build and tests without GnuTLS.
The third requires GnuTLS 3.2.0 or newer.

That means we don't have to worry about gnutls_hash_fast not
being present (introduced in GnuTLS 2.10.0).

The rest of the patches cleans up the code that deals with older
GnuTLS.

Ján Tomko (8):
  virCryptoHashBuf: return the length of the hash in bytes
  Skip vircryptotest and virfilecachetest without gnutls
  Require GnuTLS >= 3.2.0
  Deprecate GNUTLS_GCRYPT
  Remove explicit check for gnutls_rnd
  Remove explicit check for gnutls_cipher_encrypt
  Fix indentation in virCryptoHaveCipher
  Remove check for gnutls/crypto.h

 config-post.h              |  2 --
 m4/virt-gnutls.m4          | 50 +++-------------------------
 src/libvirt.c              | 83 ----------------------------------------------
 src/rpc/virnettlscontext.c |  4 +--
 src/util/vircrypto.c       | 28 ++++++++--------
 src/util/vircrypto.h       |  2 +-
 tests/qemuxml2argvtest.c   |  8 ++---
 tests/vircryptotest.c      | 26 ++++++++++-----
 tests/virfilecachetest.c   | 19 ++++++++---
 9 files changed, 58 insertions(+), 164 deletions(-)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/8] GnuTLS fixes and requirements

Posted by Michal Privoznik 5 years, 11 months ago

On 05/15/2018 02:03 PM, Ján Tomko wrote:
> The first two patches fix the build and tests without GnuTLS.
> The third requires GnuTLS 3.2.0 or newer.
> 
> That means we don't have to worry about gnutls_hash_fast not
> being present (introduced in GnuTLS 2.10.0).
> 
> The rest of the patches cleans up the code that deals with older
> GnuTLS.
> 
> Ján Tomko (8):
>   virCryptoHashBuf: return the length of the hash in bytes
>   Skip vircryptotest and virfilecachetest without gnutls
>   Require GnuTLS >= 3.2.0
>   Deprecate GNUTLS_GCRYPT
>   Remove explicit check for gnutls_rnd
>   Remove explicit check for gnutls_cipher_encrypt
>   Fix indentation in virCryptoHaveCipher
>   Remove check for gnutls/crypto.h
> 
>  config-post.h              |  2 --
>  m4/virt-gnutls.m4          | 50 +++-------------------------
>  src/libvirt.c              | 83 ----------------------------------------------
>  src/rpc/virnettlscontext.c |  4 +--
>  src/util/vircrypto.c       | 28 ++++++++--------
>  src/util/vircrypto.h       |  2 +-
>  tests/qemuxml2argvtest.c   |  8 ++---
>  tests/vircryptotest.c      | 26 ++++++++++-----
>  tests/virfilecachetest.c   | 19 ++++++++---
>  9 files changed, 58 insertions(+), 164 deletions(-)
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list