Rely on GnuTLS for md5/sha256 functions

[libvirt] [PATCH 0/5] Rely on GnuTLS for md5/sha256 functions

Ján Tomko posted 5 patches 5 years, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1526053739.git.jtomko@redhat.com

Test syntax-check passed

bootstrap.conf                      |  2 --
src/esx/esx_network_driver.c        | 22 ++++++++------
src/esx/esx_storage_backend_iscsi.c | 46 +++++++++++++++++-------------
src/esx/esx_storage_backend_vmfs.c  | 20 ++++++-------
src/util/vircrypto.c                | 57 ++++++++++++++++++++++++++-----------
src/util/vircrypto.h                | 10 +++++++
6 files changed, 100 insertions(+), 57 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/5] Rely on GnuTLS for md5/sha256 functions

Posted by Ján Tomko 5 years, 11 months ago

Ján Tomko (5):
  vircrypto: provide constants for hash sizes
  Introduce virCryptoHashBuf
  esx: use virCryptoHashBuf
  esx: Use VIR_CRYPTO_HASH_SIZE_MD5
  vircrypto: Rely on GnuTLS for hash functions

 bootstrap.conf                      |  2 --
 src/esx/esx_network_driver.c        | 22 ++++++++------
 src/esx/esx_storage_backend_iscsi.c | 46 +++++++++++++++++-------------
 src/esx/esx_storage_backend_vmfs.c  | 20 ++++++-------
 src/util/vircrypto.c                | 57 ++++++++++++++++++++++++++-----------
 src/util/vircrypto.h                | 10 +++++++
 6 files changed, 100 insertions(+), 57 deletions(-)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] Rely on GnuTLS for md5/sha256 functions

Posted by Michal Privoznik 5 years, 11 months ago

On 05/11/2018 05:50 PM, Ján Tomko wrote:
> Ján Tomko (5):
>   vircrypto: provide constants for hash sizes
>   Introduce virCryptoHashBuf
>   esx: use virCryptoHashBuf
>   esx: Use VIR_CRYPTO_HASH_SIZE_MD5
>   vircrypto: Rely on GnuTLS for hash functions
> 
>  bootstrap.conf                      |  2 --
>  src/esx/esx_network_driver.c        | 22 ++++++++------
>  src/esx/esx_storage_backend_iscsi.c | 46 +++++++++++++++++-------------
>  src/esx/esx_storage_backend_vmfs.c  | 20 ++++++-------
>  src/util/vircrypto.c                | 57 ++++++++++++++++++++++++++-----------
>  src/util/vircrypto.h                | 10 +++++++
>  6 files changed, 100 insertions(+), 57 deletions(-)
> 

ACK series, but please see my comment in 2/5 before pushing.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list